mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Nikita Yushchenko <nyushchenko@dev.rtsoft.ru>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Dmitry Krivoschekov <dkrivoschokov@dev.rtsoft.ru>,
	"Alexey Lugovskoy" <lugovskoy@dev.rtsoft.ru>,
	Thierry Reding <thierry.reding@avionic-design.de>,
	<linux-kernel@vger.kernel.org>,
	"Rob Herring" <robherring2@gmail.com>,
	Grant Likely <grant.likely@linaro.org>,
	<linuxppc-dev@lists.ozlabs.org>
Subject: Re: commit e38c0a1f breaks powerpc boards with uli1575 chip
Date: Thu, 2 Jan 2014 18:04:17 -0600	[thread overview]
Message-ID: <1388707457.11795.32.camel@snotra.buserror.net> (raw)
In-Reply-To: <1388373200.4373.25.camel@pasglop>

On Mon, 2013-12-30 at 14:13 +1100, Benjamin Herrenschmidt wrote:
> On Thu, 2013-12-19 at 08:42 +0400, Nikita Yushchenko wrote:
> > No, this does not help.
> > 
> > I've dumped the actual content of 'range' and 'addr' at the failure
> > point 
> > (i.e. ar point that returns error with e38c0a1f but passes without 
> > e38c0a1f ):
> > 
> > OF: default map, cp=0, s=10000, da=70
> > range:  01 00 00 00 00 00 00 00 00 00 00 00
> >  addr:  00 00 00 00 00 00 00 00 00 00 00 70
> 
> Something that has a #address-cells larger than 2, or more generally,
> an address field that contains more than a single number, must have
> a specific translation backend, like we have for PCI.
> 
> This is a bit annoying but originates from the original OFW stuff on
> which this stuff is based where the bus node would provide the methods
> for translation.

I can maybe see that for PCI which has a special encoding, but why is it
always needed?  E.g. if Freescale localbus had a 64-bit offset instead
of 32-bit, the child nodes would have 3 address cells, but
straightforward use of ranges would bring it down to 2 for the final
physical address.  Existing localbus nodes already have "an address
field that contains more than a single number"; it's just a simple
enough encoding that it works to treat it as if it were a single large
number.

-Scott



  reply	other threads:[~2014-01-03  0:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17  7:35 Nikita Yushchenko
2013-12-18 18:40 ` Rob Herring
2013-12-19  4:42   ` Nikita Yushchenko
2013-12-30  3:13     ` Benjamin Herrenschmidt
2014-01-03  0:04       ` Scott Wood [this message]
2013-12-19 14:24   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388707457.11795.32.camel@snotra.buserror.net \
    --to=scottwood@freescale.com \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dkrivoschokov@dev.rtsoft.ru \
    --cc=grant.likely@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lugovskoy@dev.rtsoft.ru \
    --cc=nyushchenko@dev.rtsoft.ru \
    --cc=robherring2@gmail.com \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome