From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Fabio Estevam <fabio.estevam@freescale.com>,
Shawn Guo <shawn.guo@linaro.org>
Subject: [PATCH 0/2] video: mxsfb: fix broken videomode selection
Date: Mon, 6 Jan 2014 14:17:56 +0100 [thread overview]
Message-ID: <1389014278-4903-1-git-send-email-LW@KARO-electronics.de> (raw)
The first patch in this set converts some messages that are printed
in case of errors to be error messages rather than debug messages.
The second patch fixes a bug in the video selection code that
incorrectly OR's together the 'pixelclk-active' and 'de-active'
flags from all possible video modes specified in DT into one flag.
The current code does not allow selecting one specific mode from a
list of video modes, but always uses the last one of the video modes
listed in the DT.
Since all current dts files only have one entry in their
'display-timings' node, this bug was not apparent and the fix does not
change the driver's behaviour for the current users.
b/drivers/video/mxsfb.c | 6 +--
drivers/video/mxsfb.c | 120 +++++++++++++++++++++++++++++-----------------------------------------
2 files changed, 53 insertions(+), 73 deletions(-)
next reply other threads:[~2014-01-06 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 13:17 Lothar Waßmann [this message]
2014-01-06 13:17 ` [PATCH 1/2] video: mxsfb: convert pr_debug()/dev_dbg() to pr_err()/dev_err() for error messages Lothar Waßmann
2014-01-06 13:17 ` [PATCH 2/2] video: mxsfb: fix broken videomode selection Lothar Waßmann
2014-01-08 9:04 ` [PATCH 0/2] " Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389014278-4903-1-git-send-email-LW@KARO-electronics.de \
--to=lw@karo-electronics.de \
--cc=fabio.estevam@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=shawn.guo@linaro.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome