mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chuansheng Liu <chuansheng.liu@intel.com>
To: agk@redhat.com, snitzer@redhat.com
Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com
Subject: [PATCH 3/3] dm snapshot: Calling destroy_work_on_stack() to pair with INIT_WORK_ONSTACK()
Date: Tue, 07 Jan 2014 16:56:18 +0800	[thread overview]
Message-ID: <1389084978.3650.73.camel@cliu38-desktop-build> (raw)
In-Reply-To: <1389084605.3650.66.camel@cliu38-desktop-build>


In case CONFIG_DEBUG_OBJECTS_WORK is defined, it is needed to
call destroy_work_on_stack() which frees the debug object to pair
with INIT_WORK_ONSTACK().

Signed-off-by: Liu, Chuansheng <chuansheng.liu@intel.com>
---
 drivers/md/dm-snap-persistent.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/md/dm-snap-persistent.c b/drivers/md/dm-snap-persistent.c
index 2d2b1b7..2f5a9f8 100644
--- a/drivers/md/dm-snap-persistent.c
+++ b/drivers/md/dm-snap-persistent.c
@@ -257,6 +257,7 @@ static int chunk_io(struct pstore *ps, void *area, chunk_t chunk, int rw,
 	INIT_WORK_ONSTACK(&req.work, do_metadata);
 	queue_work(ps->metadata_wq, &req.work);
 	flush_workqueue(ps->metadata_wq);
+	destroy_work_on_stack(&req.work);
 
 	return req.result;
 }
-- 
1.7.9.5




  parent reply	other threads:[~2014-01-07  8:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07  8:50 [PATCH 1/3] workqueue: " Chuansheng Liu
2014-01-07  8:53 ` [PATCH 2/3] xfs: " Chuansheng Liu
2014-01-07 11:21   ` Jeff Liu
2014-01-07 19:34     ` Ben Myers
2014-01-08  0:57     ` Liu, Chuansheng
2014-01-07  8:56 ` Chuansheng Liu [this message]
2014-01-07 15:44   ` [PATCH 3/3] dm snapshot: " Mike Snitzer
2014-01-12  3:27 ` [PATCH 1/3] workqueue: " Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389084978.3650.73.camel@cliu38-desktop-build \
    --to=chuansheng.liu@intel.com \
    --cc=agk@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®