From: Eduardo Valentin <eduardo.valentin@ti.com>
To: <rui.zhang@intel.com>
Cc: <rdunlap@infradead.org>,
Eduardo Valentin <eduardo.valentin@ti.com>,
Jean Delvare <khali@linux-fr.org>,
Guenter Roeck <linux@roeck-us.net>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 1/1] thermal: fix compilation issue on CONFIG_THERMAL_OF dependencies
Date: Tue, 7 Jan 2014 08:44:27 -0400 [thread overview]
Message-ID: <1389098667-9826-1-git-send-email-eduardo.valentin@ti.com> (raw)
In-Reply-To: <52CBF1CF.2000603@ti.com>
Users of API provided by THERMAL_OF config may suffer when
CONFIG_THERMAL=y, causing linking issues, such as:
drivers/built-in.o: In function `lm75_remove':
lm75.c:(.text+0x12bd8c): undefined reference to `thermal_zone_of_sensor_unregister'
drivers/built-in.o: In function `lm75_probe':
lm75.c:(.text+0x12c123): undefined reference to `thermal_zone_of_sensor_register'
Therefore, this patch limits the compilation build to always
have THERMAL=y, whenever THERMAL_OF=y. In this way, whenever
the API user is built, if THERMAL_OF=y, the build shall have
the full thermal support, otherwise, the thermal API will provide
stubs.
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Jean Delvare <khali@linux-fr.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
---
drivers/thermal/Kconfig | 29 ++++++++++++++++-------------
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 58f98bd..dc315e9 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -29,19 +29,6 @@ config THERMAL_HWMON
Say 'Y' here if you want all thermal sensors to
have hwmon sysfs interface too.
-config THERMAL_OF
- bool
- prompt "APIs to parse thermal data out of device tree"
- depends on OF
- default y
- help
- This options provides helpers to add the support to
- read and parse thermal data definitions out of the
- device tree blob.
-
- Say 'Y' here if you need to build thermal infrastructure
- based on device tree.
-
choice
prompt "Default Thermal governor"
default THERMAL_DEFAULT_GOV_STEP_WISE
@@ -235,3 +222,19 @@ source "drivers/thermal/samsung/Kconfig"
endmenu
endif
+
+menuconfig THERMAL_OF
+ bool
+ prompt "APIs to parse thermal data out of device tree"
+ depends on OF
+ select THERMAL
+ default y
+ help
+ This options enables DT thermal API which adds support to
+ read and parse thermal data definitions out of the
+ device tree blob. This option is mostly used by embedded
+ thermal drivers.
+
+ Say 'Y' here if you need to build thermal infrastructure
+ based on device tree.
+
--
1.8.2.1.342.gfa7285d
next prev parent reply other threads:[~2014-01-07 12:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 9:40 linux-next: Tree for Jan 06 Stephen Rothwell
2014-01-06 19:51 ` linux-next: Tree for Jan 06 (hwmon/lm75.c) Randy Dunlap
2014-01-06 20:32 ` Guenter Roeck
2014-01-07 1:09 ` [PATCH] hwmon/sensors: fix SENSORS_LM75 dependencies Randy Dunlap
2014-01-07 2:26 ` Guenter Roeck
2014-01-07 11:35 ` Eduardo Valentin
2014-01-07 12:04 ` Jean Delvare
2014-01-07 12:23 ` Eduardo Valentin
2014-01-07 12:44 ` Eduardo Valentin [this message]
2014-01-07 14:33 ` [PATCH 1/1] thermal: fix compilation issue on CONFIG_THERMAL_OF dependencies Guenter Roeck
2014-01-07 14:56 ` Eduardo Valentin
2014-01-07 15:03 ` Jean Delvare
2014-01-07 14:05 ` [PATCH] hwmon/sensors: fix SENSORS_LM75 dependencies Zhang, Rui
2014-01-07 14:57 ` Eduardo Valentin
2014-01-07 15:07 ` Jean Delvare
2014-01-07 15:28 ` Eduardo Valentin
2014-01-07 16:10 ` Guenter Roeck
2014-01-07 14:21 ` Jean Delvare
2014-01-07 16:33 ` Eduardo Valentin
2014-01-08 1:50 ` Guenter Roeck
2014-01-07 18:06 ` Randy Dunlap
2014-01-08 2:02 ` Zhang Rui
2014-01-07 16:02 ` Guenter Roeck
2014-01-07 11:33 ` linux-next: Tree for Jan 06 (hwmon/lm75.c) Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389098667-9826-1-git-send-email-eduardo.valentin@ti.com \
--to=eduardo.valentin@ti.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rdunlap@infradead.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®