From: Joe Perches <joe@perches.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: akpm@linux-foundation.org, pavel@ucw.cz, keescook@chromium.org,
geert@linux-m68k.org, jkosina@suse.cz, viro@zeniv.linux.org.uk,
davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/vsprintf: add %pT format specifier
Date: Fri, 10 Jan 2014 18:15:53 -0800 [thread overview]
Message-ID: <1389406553.2537.52.camel@joe-AO722> (raw)
In-Reply-To: <201401111059.HCH39012.MFtVHFOFQOLOJS@I-love.SAKURA.ne.jp>
On Sat, 2014-01-11 at 10:59 +0900, Tetsuo Handa wrote:
> I just added noinline_for_stack as with other functions does.
> But indeed, stack used by name[] is only 16 bytes but stack used by function
> arguments are larger than 16 bytes. We should remove noinline_for_stack ?
My recollection is that certain gcc versions don't do
well with multiple inline functions that have stack
variables.
Instead of collapsing the variables, gcc will
accumulate the stack depth of all the inlines
args instead of reusing the stack.
next prev parent reply other threads:[~2014-01-11 2:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 12:52 Tetsuo Handa
2014-01-09 18:11 ` Kees Cook
2014-01-10 23:59 ` Andrew Morton
2014-01-11 1:59 ` Tetsuo Handa
2014-01-11 2:15 ` Joe Perches [this message]
2014-01-11 2:30 ` Tetsuo Handa
2014-01-11 10:28 ` Geert Uytterhoeven
2014-01-11 12:03 ` Tetsuo Handa
2014-01-11 0:04 ` Andrew Morton
2014-01-11 1:28 ` Tetsuo Handa
2014-01-11 1:36 ` Joe Perches
2014-01-11 1:48 ` Tetsuo Handa
2014-01-11 1:57 ` Andrew Morton
2014-01-11 3:09 ` Tetsuo Handa
2014-01-11 9:50 ` Paul E. McKenney
2014-01-11 11:35 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389406553.2537.52.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=jkosina@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®