From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753660AbaAKTdB (ORCPT ); Sat, 11 Jan 2014 14:33:01 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:44925 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbaAKTdA (ORCPT ); Sat, 11 Jan 2014 14:33:00 -0500 From: Monam Agarwal To: gregkh@linuxfoundation.org, monamagarwal123@gmail.com, andreas.dilger@intel.com, peter.p.waskiewicz.jr@intel.com, tao.peng@emc.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] Staging: lustre: Use of fls to find last set bit Date: Sun, 12 Jan 2014 01:02:43 +0530 Message-Id: <1389468763-25662-1-git-send-email-monamagarwal123@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1389440466-6895-1-git-send-email-monamagarwal123@gmail.com> References: <1389440466-6895-1-git-send-email-monamagarwal123@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This introduces fls in lustre/ldlm/ldlm_extent.c to find the last set bit. It also fixes the following checkpatch.pl warning in lustre/ldlm/ldlm_extent.c WARNING: space prohibited before semicolon. The patch also fixes the following checkpatch.pl error in lustre/ldlm/ldlm_extent.c ERROR: trailing statements should be on next line Signed-off-by: Monam Agarwal --- Changes since v1: *Incorrect commit message *Use of fls function drivers/staging/lustre/lustre/ldlm/ldlm_extent.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_extent.c b/drivers/staging/lustre/lustre/ldlm/ldlm_extent.c index ac5d66a..e6fe2cb 100644 --- a/drivers/staging/lustre/lustre/ldlm/ldlm_extent.c +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_extent.c @@ -150,10 +150,12 @@ struct ldlm_interval *ldlm_interval_detach(struct ldlm_lock *l) static inline int lock_mode_to_index(ldlm_mode_t mode) { int index; + int len; LASSERT(mode != 0); LASSERT(IS_PO2(mode)); - for (index = -1; mode; index++, mode >>= 1) ; + len = fls(mode); + index = len-1; LASSERT(index < LCK_MODE_NUM); return index; } -- 1.7.9.5