From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752262AbbIPC0X (ORCPT ); Tue, 15 Sep 2015 22:26:23 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:44478 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751272AbbIPC0W (ORCPT ); Tue, 15 Sep 2015 22:26:22 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, Thomas Gleixner , alexandra.yates@linux.intel.com, Len Brown , open list , Pavel Machek Subject: Re: [PATCH] PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG Date: Wed, 16 Sep 2015 04:54:22 +0200 Message-ID: <13895814.vlsbGKVKtB@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <4506267.XG2T0Et70c@vostro.rjw.lan> References: <20150916020023.GB29235@linux> <4506267.XG2T0Et70c@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, September 16, 2015 04:48:37 AM Rafael J. Wysocki wrote: > On Wednesday, September 16, 2015 07:30:23 AM Viresh Kumar wrote: > > On 16-09-15, 03:43, Rafael J. Wysocki wrote: > > > On Tuesday, September 15, 2015 01:42:21 PM Viresh Kumar wrote: > > > > The variable 'wakeup_irq' is defined within #ifdef CONFIG_PM_SLEEP_DEBUG > > > > and used outside of it. And that breaks kernel build: > > > > > > > > /home/viresh/linux/drivers/base/power/wakeup.c:871: undefined reference to `wakeup_irq' > > > > /home/viresh/drivers/base/power/wakeup.c:871: undefined reference to `wakeup_irq' > > > > > > > > Fix it by defining the variable outside of the ifdef. > > > > > > > > Fixes: d1e59c235322 ("PM / sleep: Report interrupt that caused system wakeup") > > > > Signed-off-by: Viresh Kumar > > > > > > I've applied the v11 of the Alexandra's patch that doesn't have this problem AFAICS. > > > > For the record, as we have talked on IRC, even the v11 patch suffers > > from this problem and you will be fixing it. > > Yes, it was slightly messed up. Should be better now, though. And as a side note, for patches that are in bleeding-edge only and not in something like linux-next, you don't need to bother anyone with fixes except for me (and maybe the patch author for their education mostly). And I either drop patches that cause build problems to happen in bleeding-edge or fix them. That's what bleeding-edge is for. Thanks, Rafael