mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Nitin Gupta <ngupta@vflare.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Jerome Marchand <jmarchan@redhat.com>,
	Minchan Kim <minchan@kernel.org>
Subject: [PATCH v2 0/4]zram: locking redesign
Date: Wed, 15 Jan 2014 10:11:06 +0900	[thread overview]
Message-ID: <1389748270-15618-1-git-send-email-minchan@kernel.org> (raw)

Currently, zram->lock rw_semaphore is coarse-grained so it hurts
for scalability.
This patch try to enhance it with remove the lock in read path.

[1] uses atomic opeartion so it removes dependency of 32bit stat
from zram->lock.
[2] introduces table own lock instead of relying on zram->lock.
[3] remove free pending slot mess so it makes core very clean.
[4] finally removes zram->lock in read path and changes it with mutex.

So, output is wonderful. read/write mixed workload performs well
11 times than old and write concurrency is also enhanced because
mutex supports SPIN_ON_OWNER while rw_semaphore doesn't yet.
(I know recenty there were some effort to enhance it for rw_semaphore
from Tim Chen but not sure it got merged. Anyway, we don't need it
any more and there is no reason to prevent read-write concurrency)

Thanks.

Minchan Kim (4):
  [1] zram: use atomic operation for stat
  [2] zram: introduce zram->tb_lock
  [3] zram: remove workqueue for freeing removed pending slot
  [4] zram: Remove zram->lock in read path and change it with mutex

 drivers/staging/zram/zram_drv.c | 117 ++++++++++++++++------------------------
 drivers/staging/zram/zram_drv.h |  27 +++-------
 2 files changed, 51 insertions(+), 93 deletions(-)

-- 
1.8.5.2


             reply	other threads:[~2014-01-15  1:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15  1:11 Minchan Kim [this message]
2014-01-15  1:11 ` [PATCH v2 1/4] zram: use atomic operation for stat Minchan Kim
2014-01-15  1:11 ` [PATCH v2 2/4] zram: introduce zram->tb_lock Minchan Kim
2014-01-15  1:11 ` [PATCH v2 3/4] zram: remove workqueue for freeing removed pending slot Minchan Kim
2014-01-15  1:11 ` [PATCH v2 4/4] zram: Remove zram->lock in read path and change it with mutex Minchan Kim
2014-01-15  1:29 ` [PATCH v2 0/4]zram: locking redesign Minchan Kim
2014-01-15  1:34   ` Andrew Morton
2014-01-15  9:21 ` Jerome Marchand
2014-01-15  9:25 ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389748270-15618-1-git-send-email-minchan@kernel.org \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=jmarchan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ngupta@vflare.org \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome