From: Joe Perches <joe@perches.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: broonie@kernel.org, linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] regulator: pfuze100-regulator: Fix some checkpatch complaints
Date: Tue, 14 Jan 2014 19:02:31 -0800 [thread overview]
Message-ID: <1389754951.14001.4.camel@joe-AO722> (raw)
In-Reply-To: <1389754365-31863-1-git-send-email-festevam@gmail.com>
On Wed, 2014-01-15 at 00:52 -0200, Fabio Estevam wrote:
> Fix the following checkpatch error and warning:
While you're at it:
> diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
[]
> @@ -309,14 +309,17 @@ static int pfuze_identify(struct pfuze_chip *pfuze_chip)
[]
> + case 0x8:
> + dev_info(pfuze_chip->dev, "Assuming misprogrammed ID=0x8");
missing "\n" terminating newline and
missing break (or fallthrough comment)
> + case 0x0:
> + break;
> + default:
> + dev_warn(pfuze_chip->dev, "Illegal ID: %x\n", value);
invalid vs illegal
next prev parent reply other threads:[~2014-01-15 3:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 2:52 Fabio Estevam
2014-01-15 3:02 ` Joe Perches [this message]
2014-01-16 0:13 ` Fabio Estevam
2014-01-15 11:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389754951.14001.4.camel@joe-AO722 \
--to=joe@perches.com \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®