From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752547AbaAORIj (ORCPT ); Wed, 15 Jan 2014 12:08:39 -0500 Received: from mail-ea0-f182.google.com ([209.85.215.182]:49624 "EHLO mail-ea0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751502AbaAORIg (ORCPT ); Wed, 15 Jan 2014 12:08:36 -0500 From: Paolo Bonzini To: linux-kernel@vger.kernel.org Cc: mtosatti@redhat.com, kvm@vger.kernel.org, glommer@gmail.com Subject: [PATCH] KVM: remove useless write to vcpu->hv_clock.tsc_timestamp Date: Wed, 15 Jan 2014 18:08:11 +0100 Message-Id: <1389805691-3183-1-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After the previous patch from Marcelo, the comment before this write became obsolete. In fact, the write is unnecessary. The calls to kvm_write_tsc ultimately result in a master clock update as soon as all TSCs agree and the master clock is re-enabled. This master clock update will rewrite tsc_timestamp. So, together with the comment, delete the dead write too. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/x86.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 842abd3..0fbdced 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -1278,8 +1278,6 @@ void kvm_write_tsc(struct kvm_vcpu *vcpu, struct msr_data *msr) kvm->arch.last_tsc_write = data; kvm->arch.last_tsc_khz = vcpu->arch.virtual_tsc_khz; - /* Reset of TSC must disable overshoot protection below */ - vcpu->arch.hv_clock.tsc_timestamp = 0; vcpu->arch.last_guest_tsc = data; /* Keep track of which generation this VCPU has synchronized to */ -- 1.7.1