mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: joeyli <jlee@suse.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org,
	Josh Boyer <jwboyer@redhat.com>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Michal Marek <mmarek@suse.com>
Subject: Re: [PATCH] MODSIGN: Fix including certificate twice when the signing_key.x509
Date: Thu, 16 Jan 2014 12:03:05 +0800	[thread overview]
Message-ID: <1389844985.24105.288.camel@linux-s257.site> (raw)
In-Reply-To: <87eh49x3hh.fsf@rustcorp.com.au>

於 三，2014-01-15 於 15:09 +1030，Rusty Russell 提到：
> >
> > v2:
> > Using '$(shell /bin/pwd)' instead of '$(shell pwd)' for more
> reliable
> > between different shells
> 
> Hmm, that's not a great test for equality.  How about:
> 
>      ifneq ($(realpath .), $(realpath $(srctree)))
> 
> That should cover all the cases.
> 
> Cheers,
> Rusty. 

Yes, it's better!

Thanks for your suggestion, I will send new version with changelog
updated.

Joey Lee


  reply	other threads:[~2014-01-16  4:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-09  6:46 Lee, Chun-Yi
2014-01-15  4:39 ` Rusty Russell
2014-01-16  4:03   ` joeyli [this message]
2014-01-16 15:35   ` Michal Marek
2014-01-16 22:06     ` Rusty Russell
2014-01-16 12:31 ` David Howells
2014-01-17  5:56   ` joeyli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389844985.24105.288.camel@linux-s257.site \
    --to=jlee@suse.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jwboyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    --cc=rdunlap@xenotime.net \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome