From: David Cohen <david.a.cohen@linux.intel.com>
To: hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de, x86@kernel.org
Cc: david.a.cohen@linux.intel.com, linux-kernel@vger.kernel.org
Subject: [PATCH v3 3/3] x86: intel-mid: return proper error code from get_gpio_by_name()
Date: Thu, 16 Jan 2014 15:07:04 -0800 [thread overview]
Message-ID: <1389913624-9149-4-git-send-email-david.a.cohen@linux.intel.com> (raw)
In-Reply-To: <1389913624-9149-1-git-send-email-david.a.cohen@linux.intel.com>
This patch does a cleanup on get_gpio_by_name().
It should return an error code instead of hardcoded -1.
Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
---
arch/x86/platform/intel-mid/sfi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/platform/intel-mid/sfi.c b/arch/x86/platform/intel-mid/sfi.c
index 1d5d20b088fa..438306ebed05 100644
--- a/arch/x86/platform/intel-mid/sfi.c
+++ b/arch/x86/platform/intel-mid/sfi.c
@@ -224,7 +224,7 @@ int get_gpio_by_name(const char *name)
if (!strncmp(name, pentry->pin_name, SFI_NAME_LEN))
return pentry->pin_no;
}
- return -1;
+ return -EINVAL;
}
void __init intel_scu_device_register(struct platform_device *pdev)
--
1.8.4.2
next prev parent reply other threads:[~2014-01-16 23:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 23:07 [PATCH v3 0/3] Intel MID platform code cleanups David Cohen
2014-01-16 23:07 ` [PATCH v3 1/3] x86: intel-mid: sfi_handle_*_dev() should check for pdata error code David Cohen
2014-01-16 23:39 ` [tip:x86/intel-mid] x86, " tip-bot for David Cohen
2014-01-16 23:07 ` [PATCH v3 2/3] x86: intel-mid: check get_gpio_by_name() error code on platform code David Cohen
2014-01-16 23:39 ` [tip:x86/intel-mid] x86, intel-mid: Check " tip-bot for David Cohen
2014-01-16 23:07 ` David Cohen [this message]
2014-01-16 23:39 ` [tip:x86/intel-mid] x86, intel-mid: Return proper error code from get_gpio_by_name() tip-bot for David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389913624-9149-4-git-send-email-david.a.cohen@linux.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome