From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: peterz@infradead.org, mingo@kernel.org
Cc: linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org,
alex.shi@linaro.org
Subject: [PATCH 1/4] sched: Remove 'cpu' parameter for idle_balance()
Date: Fri, 17 Jan 2014 10:04:01 +0100 [thread overview]
Message-ID: <1389949444-14821-1-git-send-email-daniel.lezcano@linaro.org> (raw)
The cpu parameter passed to idle_balance is not needed as it could
be retrieved from the struct rq.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
kernel/sched/core.c | 2 +-
kernel/sched/fair.c | 3 ++-
kernel/sched/sched.h | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 36c951b..cf51601 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2680,7 +2680,7 @@ need_resched:
pre_schedule(rq, prev);
if (unlikely(!rq->nr_running))
- idle_balance(cpu, rq);
+ idle_balance(rq);
put_prev_task(rq, prev);
next = pick_next_task(rq);
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index b24b6cf..d601df3 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6359,12 +6359,13 @@ out:
* idle_balance is called by schedule() if this_cpu is about to become
* idle. Attempts to pull tasks from other CPUs.
*/
-void idle_balance(int this_cpu, struct rq *this_rq)
+void idle_balance(struct rq *this_rq)
{
struct sched_domain *sd;
int pulled_task = 0;
unsigned long next_balance = jiffies + HZ;
u64 curr_cost = 0;
+ int this_cpu = this_rq->cpu;
this_rq->idle_stamp = rq_clock(this_rq);
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index c2119fd..b0be4c6 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1176,7 +1176,7 @@ extern const struct sched_class idle_sched_class;
extern void update_group_power(struct sched_domain *sd, int cpu);
extern void trigger_load_balance(struct rq *rq);
-extern void idle_balance(int this_cpu, struct rq *this_rq);
+extern void idle_balance(struct rq *this_rq);
extern void idle_enter_fair(struct rq *this_rq);
extern void idle_exit_fair(struct rq *this_rq);
--
1.7.9.5
next reply other threads:[~2014-01-17 9:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 9:04 Daniel Lezcano [this message]
2014-01-17 9:04 ` [PATCH 2/4] sched: Fix race in idle_balance() Daniel Lezcano
2014-01-17 13:33 ` Peter Zijlstra
2014-01-17 13:44 ` Daniel Lezcano
2014-02-11 12:15 ` [tip:sched/core] " tip-bot for Daniel Lezcano
2014-01-17 9:04 ` [PATCH 3/4] sched: Move idle_stamp up to the core Daniel Lezcano
2014-02-11 12:16 ` [tip:sched/core] sched: Move rq->idle_stamp " tip-bot for Daniel Lezcano
2014-01-17 9:04 ` [PATCH 4/4] sched: Idle task shortcut optimization Daniel Lezcano
2014-01-17 14:09 ` Peter Zijlstra
2014-01-17 15:09 ` Daniel Lezcano
2014-01-17 15:23 ` Peter Zijlstra
2014-01-17 14:26 ` Peter Zijlstra
2014-01-17 15:06 ` Daniel Lezcano
2014-01-17 15:23 ` Peter Zijlstra
2014-01-17 15:26 ` Daniel Lezcano
2014-01-17 15:33 ` Peter Zijlstra
2014-01-17 16:06 ` Daniel Lezcano
2014-01-17 16:37 ` Daniel Lezcano
2014-01-17 16:45 ` [PATCH 1/2] sched/deadline: Fix compilation error Daniel Lezcano
2014-01-17 16:45 ` [PATCH 2/2] sched: Use idle task shortcut Daniel Lezcano
2014-01-21 8:41 ` [PATCH 4/4] sched: Idle task shortcut optimization Daniel Lezcano
2014-01-21 9:06 ` Peter Zijlstra
2014-01-21 9:28 ` Daniel Lezcano
2014-02-11 12:15 ` [tip:sched/core] sched: Remove 'cpu' parameter from idle_balance( ) tip-bot for Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389949444-14821-1-git-send-email-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=alex.shi@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome