mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, "Feng Kan" <fkan@apm.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH V3 3/3] power: reset: use syscon driver to parse reboot register from scu
Date: Fri, 17 Jan 2014 20:59:43 +0400	[thread overview]
Message-ID: <1389977983.940533034@f47.i.mail.ru> (raw)
In-Reply-To: <201401171752.47393.arnd@arndb.de>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1002 bytes --]

Пятница, 17 января 2014, 17:52 +01:00 от Arnd Bergmann <arnd@arndb.de>:
> On Wednesday 15 January 2014, Feng Kan wrote:
> > +static int __init xgene_reboot_init(void)
> >  {
> >         arm_pm_restart = xgene_restart;
> >         return 0;
> >  }
> >  device_initcall(xgene_reboot_init);
> 
> This won't work on a generic kernel, since you unconditionally set the
> pm_restart function to your own, which is broken for everything else.
> 
> Please keep the platform_driver to attach to the reboot device
> as you had before. It might be good to turn this into a generic
> "syscon-reset" driver that gets both the register number and
> the contents to write from the device node.

I am not sure but think the new driver for SYSCON GPIOs can be
reused for such purpose:
http://www.spinics.net/lists/devicetree/msg18221.html

---
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

      reply	other threads:[~2014-01-17 17:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15  1:07 [PATCH V3 0/3] Enable X-Gene platform reboot driver Feng Kan
2014-01-15  1:07 ` [PATCH V3 1/3] arm64: add reboot dts entry for X-Gene platform Feng Kan
2014-01-15  1:07 ` [PATCH V3 2/3] arm64: Enable system reset via arch Kconfig for X-Gene system Feng Kan
2014-01-15  1:07 ` [PATCH V3 3/3] power: reset: use syscon driver to parse reboot register from scu Feng Kan
2014-01-17 16:52   ` Arnd Bergmann
2014-01-17 16:59     ` Alexander Shiyan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389977983.940533034@f47.i.mail.ru \
    --to=shc_work@mail.ru \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=fkan@apm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®