mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Roland Dreier <roland@kernel.org>
Cc: Or Gerlitz <or.gerlitz@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Hefty Sean <sean.hefty@intel.com>,
	linux-rdma <linux-rdma@vger.kernel.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	target-devel <target-devel@vger.kernel.org>,
	Sagi Grimberg <sagig@mellanox.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: linux rdma 3.14 merge plans
Date: Tue, 21 Jan 2014 23:27:38 -0800	[thread overview]
Message-ID: <1390375658.5567.917.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <CAG4TOxPLEfyWsUDf4_371u=_=tOgW2v5J4zSz8xx73DfziZOZg@mail.gmail.com>

Roland & Co,

On Tue, 2014-01-21 at 16:43 -0800, Roland Dreier wrote:
> On Tue, Jan 21, 2014 at 2:00 PM, Or Gerlitz <or.gerlitz@gmail.com> wrote:
> > Roland, ping! the signature patches were posted > three months ago. We
> > deserve a response from the maintainer that goes beyond "I need to
> > think on that".
> >
> > Responsiveness was stated by Linus to be the #1 requirement from
> > kernel maintainers.
> 
> Or, I'm not sure what response you're after from me.  Linus has also
> said that maintainers should say "no" a lot more
> (http://lwn.net/Articles/571995/) so maybe you want me to say, "No, I
> won't merge this patch set, since it adds a bunch of complexity to
> support a feature no one really cares about."  Is that it? 

The patch set proposed by Sagi + Or is modest in terms of LOC to core IB
code, and includes mostly mlx5 specific driver changes that enables HW
offloads.

> (And yes I
> am skeptical about this stuff — I work at an enterprise storage
> company and even here it's hard to find anyone who cares about
> DIF/DIX, especially offload features that stop it from being
> end-to-end)
> 

My understanding is most HBAs capable of T10 PI offload in DIX PASS +
VERIFY mode are already implementing DIX INSERT + STRIP modes in various
capacities to support legacy environments.

Beyond the DIX INSERT + STRIP case for enterprise storage, the amount of
FC + SAS HBAs that already support T10 PI metadata is substantial.

> I'm sure you're not expecting me to say, "Sure, I'll merge it without
> understanding the problem it's solving or how it's doing that,"
> especially given the your recent history of pushing me to merge stuff
> like the IP-RoCE patches back when they broke the userspace ABI.

With the merge window now upon us, there is a understandable reluctance
to merge new features.  Given the amount of time the series has spent on
the list, it is however a good candidate to consider for an exception.

Short of that, are you planning to accept the series for the next round
once the current merge window closes..?

We'd really like to start enabling fabrics with these types of offloads
for v3.15. 

> I'd really rather spend my time on something actually useful like
> cleaning up softroce.
> 

+1 for softroce + T10 PI support!

--nab


  parent reply	other threads:[~2014-01-22  7:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAJZOPZ+4yQ-sT=ks7+eiJjkxOjy5w=BmG16JVcUPiuVsof7qEA@mail.gmail.com>
     [not found] ` <CAG4TOxOMmvFWnkU3DBn33rscEKh2_YfbUCKY=iY8PCVN3+nEsA@mail.gmail.com>
     [not found]   ` <52CD1C68.4050406@mellanox.com>
     [not found]     ` <1389645171.5567.459.camel@haakon3.risingtidesystems.com>
     [not found]       ` <1389820541.5567.543.camel@haakon3.risingtidesystems.com>
     [not found]         ` <CAG4TOxNa32sLxifPx_f8sW04B_qSh01WWfWjRvam6fjvFLDXSQ@mail.gmail.com>
     [not found]           ` <1389906852.5567.668.camel@haakon3.risingtidesystems.com>
     [not found]             ` <CAG4TOxPeYQ=e5LdJft1Hkx8donUQjJaKDEAv3iRLGxPYJQ_b9w@mail.gmail.com>
     [not found]               ` <1390102949.5567.749.camel@haakon3.risingtidesystems.com>
     [not found]                 ` <52DBB4F1.4020400@mellanox.com>
     [not found]                   ` <CAJZOPZJFbcTh2zO8mos0M+gv0LW-Gmh877Vxe4tLvfPX19oqTw@mail.gmail.com>
2014-01-21 22:00                     ` Or Gerlitz
2014-01-22  0:43                       ` Roland Dreier
2014-01-22  4:10                         ` Or Gerlitz
2014-01-22  7:27                         ` Nicholas A. Bellinger [this message]
2014-02-07  0:02                           ` Nicholas A. Bellinger
2014-02-07  0:04                             ` Roland Dreier
2014-02-25 21:10                               ` Or Gerlitz
2014-03-05  9:54                               ` Nicholas A. Bellinger
2014-03-05 15:18                                 ` Roland Dreier
2014-03-05 15:38                                   ` Or Gerlitz
2014-03-05 19:03                                   ` Nicholas A. Bellinger
2014-03-07  5:07                                     ` Devesh Sharma
2014-03-07 19:31                                       ` Roland Dreier
2014-03-10  9:00                                         ` Devesh Sharma
     [not found]                         ` <52DF93D3.6030509@dev.mellanox.co.il>
2014-01-28 21:02                           ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390375658.5567.917.camel@haakon3.risingtidesystems.com \
    --to=nab@linux-iscsi.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=or.gerlitz@gmail.com \
    --cc=roland@kernel.org \
    --cc=sagig@mellanox.com \
    --cc=sean.hefty@intel.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®