From: Peng Tao <bergwolf@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
"John L. Hammond" <john.hammond@intel.com>,
Peng Tao <bergwolf@gmail.com>,
Andreas Dilger <andreas.dilger@intel.com>
Subject: [PATCH v2 RESEND 3/8] staging/lustre/llite: pass correct pointer to obd_iocontrol()
Date: Wed, 22 Jan 2014 21:36:14 +0800 [thread overview]
Message-ID: <1390397779-30975-4-git-send-email-bergwolf@gmail.com> (raw)
In-Reply-To: <1390397779-30975-1-git-send-email-bergwolf@gmail.com>
From: "John L. Hammond" <john.hammond@intel.com>
In copy_and_ioctl() use the kernel space copy as the karg to
obd_iocontrol().
Lustre-change: http://review.whamcloud.com/6274
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3283
Signed-off-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Sebastien Buisson <sebastien.buisson@bull.net>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
---
drivers/staging/lustre/lustre/llite/dir.c | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/dir.c b/drivers/staging/lustre/lustre/llite/dir.c
index 22d0acc9..1b217c8 100644
--- a/drivers/staging/lustre/lustre/llite/dir.c
+++ b/drivers/staging/lustre/lustre/llite/dir.c
@@ -1048,20 +1048,25 @@ progress:
}
-static int copy_and_ioctl(int cmd, struct obd_export *exp, void *data, int len)
+static int copy_and_ioctl(int cmd, struct obd_export *exp,
+ const void __user *data, size_t size)
{
- void *ptr;
+ void *copy;
int rc;
- OBD_ALLOC(ptr, len);
- if (ptr == NULL)
+ OBD_ALLOC(copy, size);
+ if (copy == NULL)
return -ENOMEM;
- if (copy_from_user(ptr, data, len)) {
- OBD_FREE(ptr, len);
- return -EFAULT;
+
+ if (copy_from_user(copy, data, size)) {
+ rc = -EFAULT;
+ goto out;
}
- rc = obd_iocontrol(cmd, exp, len, data, NULL);
- OBD_FREE(ptr, len);
+
+ rc = obd_iocontrol(cmd, exp, size, copy, NULL);
+out:
+ OBD_FREE(copy, size);
+
return rc;
}
--
1.7.9.5
next prev parent reply other threads:[~2014-01-22 13:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 13:36 [PATCH v2 RESEND 0/8] staging/lustre: sync with external tree Peng Tao
2014-01-22 13:36 ` [PATCH v2 RESEND 1/8] staging/lustre/llite: remove ll_d_root_ops Peng Tao
2014-01-22 13:36 ` [PATCH v2 RESEND 2/8] staging/lustre/llite: don't d_add for create only files Peng Tao
2014-01-22 13:36 ` Peng Tao [this message]
2014-01-22 13:36 ` [PATCH v2 RESEND 4/8] staging/lustre/idl: remove LASSERT/CLASSERT from lustre_idl.h Peng Tao
2014-01-22 13:36 ` [PATCH v2 RESEND 5/8] staging/lustre/mgs: set_param -P option that sets value permanently Peng Tao
2014-01-22 13:36 ` [PATCH v2 RESEND 6/8] staging/lustre/obdclass: remove extra break in class_process_config Peng Tao
2014-02-07 17:43 ` Greg Kroah-Hartman
2014-02-08 1:52 ` Peng Tao
2014-01-22 13:36 ` [PATCH v2 RESEND 7/8] staging/lustre/lustre_user.h: remove obsolete comments Peng Tao
2014-01-22 13:36 ` [PATCH v2 RESEND 8/8] staging/lustre/ptlrpc: flock deadlock detection does not work Peng Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390397779-30975-4-git-send-email-bergwolf@gmail.com \
--to=bergwolf@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.hammond@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome