From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756017AbaAVPaV (ORCPT ); Wed, 22 Jan 2014 10:30:21 -0500 Received: from mail-pb0-f52.google.com ([209.85.160.52]:43751 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755254AbaAVPaR (ORCPT ); Wed, 22 Jan 2014 10:30:17 -0500 Message-ID: <1390404614.27806.23.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH 1/1] Per socket value for max datagram queue length From: Eric Dumazet To: Dan Ballard Cc: Lennart Poettering , kay.sievers@vrfy.org, Arnd Bergmann , "David S. Miller" , Eric Dumazet , Eliezer Tamir , Neil Horman , Li Zefan , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Date: Wed, 22 Jan 2014 07:30:14 -0800 In-Reply-To: <13e8aad86903481261581de7c29444e3@mindstab.net> References: <13e8aad86903481261581de7c29444e3@mindstab.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2014-01-22 at 07:11 -0800, Dan Ballard wrote: > Provides a new option for setsockopt SO_MAX_DGRAM_QLEN that sets and > gets a socket specific max datagram queue length. Currently each socket > has one but it's only ever initialized from > /proc/sys/net/unix/max_dgram_qlen and then never adjustable later. Now > each socket can have it individually tweaked during it's life. > Your patch suffers from many problems. It breaks listen() It doesn't compile on a lot of arches. sk_max_ack_backlog is an unsigned short. max_dgram_qlen is used, but only for Unix sockets at this time Try : "git grep -n max_dgram_qlen" for details > Signed-off-by: Dan Ballard > --- > include/uapi/asm-generic/socket.h | 2 ++ > net/core/sock.c | 7 +++++++ > 2 files changed, 9 insertions(+) > > diff --git a/include/uapi/asm-generic/socket.h > b/include/uapi/asm-generic/socket.h > index 38f14d0..f8c3e6b 100644 > --- a/include/uapi/asm-generic/socket.h > +++ b/include/uapi/asm-generic/socket.h > @@ -80,4 +80,6 @@ > > #define SO_MAX_PACING_RATE 47 > > +#define SO_MAX_DGRAM_QLEN 48 > + > #endif /* __ASM_GENERIC_SOCKET_H */ > diff --git a/net/core/sock.c b/net/core/sock.c > index 5393b4b..1ff69d1 100644 > --- a/net/core/sock.c > +++ b/net/core/sock.c > @@ -915,6 +915,10 @@ set_rcvbuf: > sk->sk_max_pacing_rate); > break; > > + case SO_MAX_DGRAM_QLEN: > + sk->sk_max_ack_backlog = val; > + break; > + > default: > ret = -ENOPROTOOPT; > break; > @@ -1182,6 +1186,9 @@ int sock_getsockopt(struct socket *sock, int > level, int optname, > v.val = sk->sk_max_pacing_rate; > break; > > + case SO_MAX_DGRAM_QLEN: > + v.val = sk->sk_max_ack_backlog; > + break; > default: > return -ENOPROTOOPT; > }