From: Toshi Kani <toshi.kani@hp.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: Borislav Petkov <bp@alien8.de>,
Linux EFI <linux-efi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>,
Matthew Garrett <mjg59@srcf.ucam.org>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 0/5] EFI memmap and other fixes, v3
Date: Thu, 23 Jan 2014 09:30:19 -0700 [thread overview]
Message-ID: <1390494619.1792.482.camel@misato.fc.hp.com> (raw)
In-Reply-To: <20140123090654.GA17297@console-pimps.org>
On Thu, 2014-01-23 at 09:06 +0000, Matt Fleming wrote:
> On Sat, 18 Jan, at 12:48:13PM, Borislav Petkov wrote:
> > From: Borislav Petkov <bp@suse.de>
> >
> > Hi all,
> >
> > this is the latest incarnation which should hopefully work just fine. It
> > tpasses esting at least on all our boxes so we have *some* coverage.
> >
> > It took us a long time to debug the unmapping path and realize how
> > exactly we're doing the PGD sharing between the kernel and the EFI page
> > table. I've commented on this verbosely in 4/5 for future reference
> > because this stuff is not trivial.
> >
> > We definitely should have this in mind when we do more changes on how we
> > handle the EFI page table and what we do with it, maybe even decouple it
> > completely from the kernel one. I dunno - it is all future stuff to pay
> > attention to.
> >
> > Anyway, if anyone with an EFI box wants to give it a run, feel free to
> > do so.
> >
> > As always, all comments and suggestions are appreciated.
>
> Thanks Borislav. I picked these up and applied them to my 'next' branch.
>
> You'll notice that I haven't stuck them in my 'urgent' branch, so these
> won't be sent to Linus before v3.15 despite the fact that they're bug
> fixes. I think Toshi's box is special enough that most people shouldn't
> hit this issue, and since these patches involve rewriting the way we do
> SetVirtualAddressMap() I'm happy for people to hammer on the stuff that
> did make it into the merge window without this added complication.
>
> Having said that, if people think it's worth the effort I don't mind
> setting up a new branch containing this series that can be sent to Linus
> much sooner.
Since this issue is quite serious on our systems (3.14 kernels won't
boot up), I'd really appreciate if the fixes can be made into some
3.14-rc. It can hit on any EFI systems with large memory.
Thanks,
-Toshi
next prev parent reply other threads:[~2014-01-23 16:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-18 11:48 Borislav Petkov
2014-01-18 11:48 ` [PATCH 1/5] x86, ptdump: Add the functionality to dump an arbitrary pagetable Borislav Petkov
2014-01-18 11:48 ` [PATCH 2/5] efi: Dump the EFI page table Borislav Petkov
2014-01-20 13:38 ` Matt Fleming
2014-01-20 13:41 ` Borislav Petkov
2014-01-18 11:48 ` [PATCH 3/5] x86, pageattr: Export page unmapping interface Borislav Petkov
2014-01-18 11:48 ` [PATCH 4/5] efi: Make efi virtual runtime map passing more robust Borislav Petkov
2014-01-18 11:48 ` [PATCH 5/5] efi: Split efi_enter_virtual_mode Borislav Petkov
2014-01-20 13:44 ` Matt Fleming
2014-01-20 13:46 ` Borislav Petkov
2014-01-20 14:48 ` Matt Fleming
2014-01-23 9:06 ` [PATCH 0/5] EFI memmap and other fixes, v3 Matt Fleming
2014-01-23 16:30 ` Toshi Kani [this message]
2014-01-23 16:51 ` Borislav Petkov
2014-01-23 16:56 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390494619.1792.482.camel@misato.fc.hp.com \
--to=toshi.kani@hp.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome