From: Ian Campbell <Ian.Campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: <linux-kernel@vger.kernel.org>, <konrad.wilk@oracle.com>,
<boris.ostrovsky@oracle.com>, <david.vrabel@citrix.com>,
<xen-devel@lists.xenproject.org>,
<stefano.stabellini@eu.citrix.com>, <patches@linaro.org>
Subject: Re: [PATCH] xen/gnttab: Use phys_addr_t to describe the grant frame base address
Date: Tue, 28 Jan 2014 09:35:46 +0000 [thread overview]
Message-ID: <1390901746.7753.5.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <1390871025-29079-1-git-send-email-julien.grall@linaro.org>
On Tue, 2014-01-28 at 01:03 +0000, Julien Grall wrote:
> On ARM, address size can be 32 bits or 64 bits (if CONFIG_ARCH_PHYS_ADDR_T_64BIT
> is enabled).
> We can't assume that the grant frame base address will always fits in an
> unsigned long. Use phys_addr_t instead of unsigned long as argument for
> gnttab_setup_auto_xlat_frames.
Strictly speaking I think it would be wrong for the tools to provide a
grant frame address which only kernels with LPAE support enabled could
use, so the issue is more theoretical than a real danger.
The patch is still correct though.
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2014-01-28 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 1:03 Julien Grall
2014-01-28 9:35 ` Ian Campbell [this message]
2014-01-28 10:45 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390901746.7753.5.camel@kazak.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=julien.grall@linaro.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®