From: Borislav Petkov <bp@alien8.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Borislav Petkov <bp@suse.de>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Robert Richter <rric@kernel.org>, David Ahern <dsahern@gmail.com>,
Namhyung Kim <namhyung@gmail.com>
Subject: [PATCH 3/3] perf: Drop prefetch.h
Date: Wed, 5 Feb 2014 15:51:54 +0100 [thread overview]
Message-ID: <1391611914-26054-4-git-send-email-bp@alien8.de> (raw)
In-Reply-To: <1391611914-26054-1-git-send-email-bp@alien8.de>
From: Borislav Petkov <bp@suse.de>
This was needed at the time before e66eed651fd1 ("list: remove
prefetching from regular list iterators") where the list iterators did
prefetch elements. This turned out to be counter-productive and hurt
performance and they were removed. Which makes the prefetch.h header
unused so drop it.
Signed-off-by: Borislav Petkov <bp@suse.de>
---
tools/perf/Makefile.perf | 1 -
tools/perf/util/include/linux/list.h | 1 -
tools/perf/util/include/linux/prefetch.h | 6 ------
3 files changed, 8 deletions(-)
delete mode 100644 tools/perf/util/include/linux/prefetch.h
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 1afe52f72d1c..f4f2c3a3c094 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -219,7 +219,6 @@ LIB_H += util/include/linux/kernel.h
LIB_H += util/include/linux/list.h
LIB_H += util/include/linux/export.h
LIB_H += util/include/linux/poison.h
-LIB_H += util/include/linux/prefetch.h
LIB_H += util/include/linux/rbtree.h
LIB_H += util/include/linux/rbtree_augmented.h
LIB_H += util/include/linux/string.h
diff --git a/tools/perf/util/include/linux/list.h b/tools/perf/util/include/linux/list.h
index 1d928a0ce997..bfe0a2afd0d2 100644
--- a/tools/perf/util/include/linux/list.h
+++ b/tools/perf/util/include/linux/list.h
@@ -1,5 +1,4 @@
#include <linux/kernel.h>
-#include <linux/prefetch.h>
#include "../../../../include/linux/list.h"
diff --git a/tools/perf/util/include/linux/prefetch.h b/tools/perf/util/include/linux/prefetch.h
deleted file mode 100644
index 7841e485d8c3..000000000000
--- a/tools/perf/util/include/linux/prefetch.h
+++ /dev/null
@@ -1,6 +0,0 @@
-#ifndef PERF_LINUX_PREFETCH_H
-#define PERF_LINUX_PREFETCH_H
-
-static inline void prefetch(void *a __attribute__((unused))) { }
-
-#endif
--
1.8.5.2.192.g7794a68
next prev parent reply other threads:[~2014-02-05 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 14:51 [PATCH 0/3] perf-tool: Move last fs* bits Borislav Petkov
2014-02-05 14:51 ` [PATCH 1/3] perf: Move fs.* to lib/api/fs/ Borislav Petkov
2014-02-05 14:51 ` [PATCH 2/3] perf: Move hash.h header Borislav Petkov
2014-02-22 17:59 ` [tip:perf/core] perf tools: " tip-bot for Borislav Petkov
2014-02-05 14:51 ` Borislav Petkov [this message]
2014-02-22 17:59 ` [tip:perf/core] perf tools: Drop prefetch.h tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391611914-26054-4-git-send-email-bp@alien8.de \
--to=bp@alien8.de \
--cc=acme@infradead.org \
--cc=bp@suse.de \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@gmail.com \
--cc=peterz@infradead.org \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome