mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>,
	David Herrmann <dh.herrmann@gmail.com>,
	Jiri Kosina <jkosina@suse.cz>,
	Frank Praznik <frank.praznik@oh.rr.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/9] HID: remove hidinput_input_event handler
Date: Wed,  5 Feb 2014 16:33:19 -0500	[thread overview]
Message-ID: <1391636004-29354-5-git-send-email-benjamin.tissoires@redhat.com> (raw)
In-Reply-To: <1391636004-29354-1-git-send-email-benjamin.tissoires@redhat.com>

All the different transport drivers use now the generic event handling
in hid-input. We can remove the handler definitively now.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
 drivers/hid/hid-input.c | 4 +---
 include/linux/hid.h     | 4 ----
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 1f0d49c..68db2db 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -1266,9 +1266,7 @@ static struct hid_input *hidinput_allocate(struct hid_device *hid)
 	}
 
 	input_set_drvdata(input_dev, hid);
-	if (hid->ll_driver->hidinput_input_event)
-		input_dev->event = hid->ll_driver->hidinput_input_event;
-	else if (hid->ll_driver->request || hid->hid_output_raw_report)
+	if (hid->ll_driver->request || hid->hid_output_raw_report)
 		input_dev->event = hidinput_input_event;
 	input_dev->open = hidinput_open;
 	input_dev->close = hidinput_close;
diff --git a/include/linux/hid.h b/include/linux/hid.h
index dddcad0..38c307b 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -675,7 +675,6 @@ struct hid_driver {
  * @stop: called on remove
  * @open: called by input layer on open
  * @close: called by input layer on close
- * @hidinput_input_event: event input event (e.g. ff or leds)
  * @parse: this method is called only once to parse the device data,
  *	   shouldn't allocate anything to not leak memory
  * @request: send report request to device (e.g. feature report)
@@ -693,9 +692,6 @@ struct hid_ll_driver {
 
 	int (*power)(struct hid_device *hdev, int level);
 
-	int (*hidinput_input_event) (struct input_dev *idev, unsigned int type,
-			unsigned int code, int value);
-
 	int (*parse)(struct hid_device *hdev);
 
 	void (*request)(struct hid_device *hdev,
-- 
1.8.3.1


  parent reply	other threads:[~2014-02-05 21:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05 21:33 [PATCH v2 0/9] HID: spring cleanup v2 Benjamin Tissoires
2014-02-05 21:33 ` [PATCH v2 1/9] HID: add inliners for ll_driver transport-layer callbacks Benjamin Tissoires
2014-02-05 21:33 ` [PATCH v2 2/9] HID: logitech-dj: remove hidinput_input_event Benjamin Tissoires
2014-02-05 21:33 ` [PATCH v2 3/9] HID: HIDp: remove hidp_hidinput_event Benjamin Tissoires
2014-02-05 21:33 ` Benjamin Tissoires [this message]
2014-02-05 21:33 ` [PATCH v2 5/9] HID: HIDp: remove duplicated coded Benjamin Tissoires
2014-02-05 21:33 ` [PATCH v2 6/9] HID: usbhid: remove duplicated code Benjamin Tissoires
2014-02-05 21:33 ` [PATCH v2 7/9] HID: remove hid_get_raw_report in struct hid_device Benjamin Tissoires
2014-02-17 13:15   ` Jiri Kosina
2014-02-17 13:19     ` Benjamin Tissoires
2014-02-17 13:20       ` Jiri Kosina
2014-02-05 21:33 ` [PATCH v2 8/9] HID: introduce helper to access hid_output_raw_report() Benjamin Tissoires
2014-02-05 21:33 ` [PATCH v2 9/9] HID: Add HID transport driver documentation Benjamin Tissoires
2014-02-12 10:13 ` [PATCH v2 0/9] HID: spring cleanup v2 David Herrmann
2014-02-13 15:11   ` Benjamin Tissoires
2014-02-17 13:19 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391636004-29354-5-git-send-email-benjamin.tissoires@redhat.com \
    --to=benjamin.tissoires@redhat.com \
    --cc=benjamin.tissoires@gmail.com \
    --cc=dh.herrmann@gmail.com \
    --cc=frank.praznik@oh.rr.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®