From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <ak@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Matt Fleming <matt.fleming@intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: [PATCH v1 09/11] x86: perf: intel_pt: Add core dump functionality
Date: Thu, 6 Feb 2014 12:50:32 +0200 [thread overview]
Message-ID: <1391683834-29868-10-git-send-email-alexander.shishkin@linux.intel.com> (raw)
In-Reply-To: <1391683834-29868-1-git-send-email-alexander.shishkin@linux.intel.com>
Intel Processor Trace (PT) data can be used in process core dumps. This
is done by implementing itrace code dump related hooks that configure and
output trace data to a core file. The driver will also include the list
of PT capabilities in itrace core dump notes so that the decoder can make
assumptions about the binary stream.
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
arch/x86/kernel/cpu/intel_pt.h | 2 +
arch/x86/kernel/cpu/perf_event_intel_pt.c | 74 +++++++++++++++++++++++++++++++
2 files changed, 76 insertions(+)
diff --git a/arch/x86/kernel/cpu/intel_pt.h b/arch/x86/kernel/cpu/intel_pt.h
index dd69092..befde1f 100644
--- a/arch/x86/kernel/cpu/intel_pt.h
+++ b/arch/x86/kernel/cpu/intel_pt.h
@@ -84,6 +84,8 @@ enum pt_capabilities {
struct pt_pmu {
struct itrace_pmu itrace;
u32 caps[4 * PT_CPUID_LEAVES];
+ char *capstr;
+ unsigned int caplen;
};
/**
diff --git a/arch/x86/kernel/cpu/perf_event_intel_pt.c b/arch/x86/kernel/cpu/perf_event_intel_pt.c
index af1482d..cb03594 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_pt.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_pt.c
@@ -24,6 +24,7 @@
#include <linux/slab.h>
#include <linux/debugfs.h>
#include <linux/device.h>
+#include <linux/coredump.h>
#include <asm-generic/sizes.h>
#include <asm/perf_event.h>
@@ -88,6 +89,34 @@ static void pt_cap_set(enum pt_capabilities cap, u32 val)
pt_pmu.caps[idx] = (val << shift) & cd->mask;
}
+/**
+ * pt_cap_string - format PT capabilities into an ascii string
+ *
+ * We need to include PT capabilities in the core dump note so that the
+ * decoder knows what to expect in the binary stream.
+ */
+static void pt_cap_string(void)
+{
+ char *capstr;
+ int pos, i;
+
+ capstr = kzalloc(PAGE_SIZE, GFP_KERNEL);
+ if (!capstr)
+ return;
+
+ for (i = 0, pos = 0; i < ARRAY_SIZE(pt_caps) && pos < PAGE_SIZE; i++) {
+ pos += snprintf(&capstr[pos], PAGE_SIZE - pos, "%s:%x%c",
+ pt_caps[i].name, pt_cap_get(i),
+ i == ARRAY_SIZE(pt_caps) - 1 ? 0 : ',');
+ }
+
+ if (pt_pmu.capstr)
+ kfree(pt_pmu.capstr);
+
+ pt_pmu.capstr = capstr;
+ pt_pmu.caplen = pos;
+}
+
static ssize_t pt_cap_show(struct device *cdev,
struct device_attribute *attr,
char *buf)
@@ -114,6 +143,7 @@ static ssize_t pt_cap_store(struct device *cdev,
return -EINVAL;
pt_cap_set(cap, new);
+ pt_cap_string();
return size;
}
@@ -179,6 +209,7 @@ static int __init pt_pmu_hw_init(void)
attrs[i] = &de_attrs[i].attr.attr;
}
+ pt_cap_string();
pt_cap_group.attrs = attrs;
return 0;
@@ -1070,6 +1101,46 @@ out:
pt_event_start(event, 0);
}
+static size_t pt_trace_core_size(struct perf_event *event)
+{
+ return pt_pmu.caplen;
+}
+
+static unsigned int pt_core_copy(void *data, const void *src,
+ unsigned int len)
+{
+ struct coredump_params *cprm = data;
+
+ if (dump_emit(cprm, src, len))
+ return 0;
+
+ return len;
+}
+
+static void pt_trace_core_output(struct coredump_params *cprm,
+ struct perf_event *event,
+ unsigned long len)
+{
+ struct pt_buffer *buf;
+ u64 from, to;
+ int ret;
+
+ buf = itrace_priv(event);
+
+ if (!dump_emit(cprm, pt_pmu.capstr, pt_pmu.caplen))
+ return;
+
+ to = local64_read(&buf->head);
+ if (to < len)
+ from = buf->size + to - len;
+ else
+ from = to - len;
+
+ ret = pt_buffer_output(buf, from, to, pt_core_copy, cprm);
+ if (ret < 0)
+ pr_warn("%s: failed to copy trace data\n", __func__);
+}
+
static __init int pt_init(void)
{
int ret, cpu;
@@ -1097,6 +1168,9 @@ static __init int pt_init(void)
pt_pmu.itrace.free_buffer = pt_buffer_itrace_free;
pt_pmu.itrace.sample_trace = pt_trace_sampler_trace;
pt_pmu.itrace.sample_output = pt_trace_sampler_output;
+ pt_pmu.itrace.core_size = pt_trace_core_size;
+ pt_pmu.itrace.core_output = pt_trace_core_output;
+ pt_pmu.itrace.coredump_config = RTIT_CTL_TSC_EN | RTIT_CTL_DISRETC;
pt_pmu.itrace.name = "intel_pt";
ret = itrace_pmu_register(&pt_pmu.itrace);
--
1.8.5.2
next prev parent reply other threads:[~2014-02-06 10:52 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 10:50 [PATCH v1 00/11] perf: Add support for Intel Processor Trace Alexander Shishkin
2014-02-06 10:50 ` [PATCH v1 01/11] x86: Add Intel Processor Trace (INTEL_PT) cpu feature detection Alexander Shishkin
2014-02-06 10:50 ` [PATCH v1 02/11] perf: Abstract ring_buffer backing store operations Alexander Shishkin
2014-02-06 10:50 ` [PATCH v1 03/11] perf: Allow for multiple ring buffers per event Alexander Shishkin
2014-02-17 14:33 ` Peter Zijlstra
2014-02-18 2:36 ` Andi Kleen
2014-03-14 10:38 ` Peter Zijlstra
2014-03-14 14:10 ` Andi Kleen
2014-03-18 14:06 ` Alexander Shishkin
2014-02-19 22:02 ` Dave Hansen
2014-03-10 9:59 ` Alexander Shishkin
2014-03-10 17:24 ` Andi Kleen
2014-03-14 10:44 ` Peter Zijlstra
2014-03-14 14:13 ` Andi Kleen
2014-03-14 10:41 ` Peter Zijlstra
2014-05-07 15:26 ` Peter Zijlstra
2014-05-07 19:25 ` Ingo Molnar
2014-05-07 21:08 ` Andi Kleen
2014-05-07 21:22 ` Peter Zijlstra
2014-05-08 3:26 ` Alexander Shishkin
2014-05-08 4:05 ` Alexander Shishkin
2014-05-08 9:08 ` Alexander Shishkin
2014-05-08 12:34 ` Alexander Shishkin
2014-05-08 12:41 ` Peter Zijlstra
2014-05-08 12:46 ` Alexander Shishkin
2014-05-08 14:16 ` Peter Zijlstra
2014-02-06 10:50 ` [PATCH v1 04/11] itrace: Infrastructure for instruction flow tracing units Alexander Shishkin
2014-02-06 10:50 ` [PATCH v1 05/11] itrace: Add functionality to include traces in perf event samples Alexander Shishkin
2014-02-06 10:50 ` [PATCH v1 06/11] itrace: Add functionality to include traces in process core dumps Alexander Shishkin
2014-02-06 10:50 ` [PATCH v1 07/11] x86: perf: intel_pt: Intel PT PMU driver Alexander Shishkin
2014-02-06 20:29 ` Andi Kleen
2014-02-17 14:44 ` Peter Zijlstra
2014-02-17 16:07 ` Andi Kleen
2014-02-17 14:46 ` Peter Zijlstra
2014-02-18 12:42 ` Alexander Shishkin
2014-02-06 10:50 ` [PATCH v1 08/11] x86: perf: intel_pt: Add sampling functionality Alexander Shishkin
2014-02-06 10:50 ` Alexander Shishkin [this message]
2014-02-06 20:36 ` [PATCH v1 09/11] x86: perf: intel_pt: Add core dump functionality Andi Kleen
2014-02-07 9:03 ` Alexander Shishkin
2014-02-06 23:59 ` Andi Kleen
2014-02-07 9:09 ` Alexander Shishkin
2014-02-06 10:50 ` [PATCH v1 10/11] x86: perf: intel_bts: Add BTS PMU driver Alexander Shishkin
2014-02-06 10:50 ` [PATCH v1 11/11] x86: perf: intel_bts: Add core dump related functionality Alexander Shishkin
2014-02-06 23:57 ` Andi Kleen
2014-02-07 9:02 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391683834-29868-10-git-send-email-alexander.shishkin@linux.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®