From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751620AbaBGS40 (ORCPT ); Fri, 7 Feb 2014 13:56:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58249 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751233AbaBGS4Z (ORCPT ); Fri, 7 Feb 2014 13:56:25 -0500 From: Prarit Bhargava To: linux-kernel@vger.kernel.org Cc: Prarit Bhargava , Dominik Brodowski , Thomas Renninger , "Rafael J. Wysocki" , Alan Cox , One Thousand Gnomes Subject: [PATCH] tools, cpupower Fix error condition in cmd_freq_set() Date: Fri, 7 Feb 2014 13:55:53 -0500 Message-Id: <1391799353-19517-1-git-send-email-prarit@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On a system which has only 4.00GHz set as the only available frequency, [root@amd-pike-05 ~]# cpupower frequency-info current policy: frequency should be within 4.00 GHz and 4.00 GHz. The governor "userspace" may decide which speed to use within this range. setting the frequency to 2.8GHz does not return an error. [root@amd-pike-05 ~]# cpupower frequency-set --freq 2800MHz Setting cpu: 0 Setting cpu: 1 Setting cpu: 2 Setting cpu: 3 Setting cpu: 4 Setting cpu: 5 Setting cpu: 6 Setting cpu: 7 [root@amd-pike-05 ~]# The frequency set error should stop with an error message after the first failure. Fix the error return in cmd_freq_set() to read errors as less than zero. Signed-off-by: Prarit Bhargava Cc: Dominik Brodowski Cc: Thomas Renninger Cc: "Rafael J. Wysocki" Cc: Alan Cox Cc: One Thousand Gnomes --- tools/power/cpupower/utils/cpufreq-set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/power/cpupower/utils/cpufreq-set.c b/tools/power/cpupower/utils/cpufreq-set.c index a416de8..e5f78623 100644 --- a/tools/power/cpupower/utils/cpufreq-set.c +++ b/tools/power/cpupower/utils/cpufreq-set.c @@ -320,7 +320,7 @@ int cmd_freq_set(int argc, char **argv) printf(_("Setting cpu: %d\n"), cpu); ret = do_one_cpu(cpu, &new_pol, freq, policychange); - if (ret) + if (ret < 0) break; } -- 1.7.9.3