From: Joe Perches <joe@perches.com>
To: Petr Vandrovec <petr@vandrovec.name>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] ncpfs: Convert DPRINTK/DDPRINTK to ncp_dbg
Date: Sun, 09 Feb 2014 16:53:44 -0800 [thread overview]
Message-ID: <1391993624.3178.11.camel@joe-AO722> (raw)
In-Reply-To: <29642e506f8f78fd1308326c1c7c2e0a8a0be056.1391985629.git.joe@perches.com>
On Sun, 2014-02-09 at 14:48 -0800, Joe Perches wrote:
> Use a more current logging style and enable use of dynamic debugging.
[]
> diff --git a/fs/ncpfs/ncp_fs.h b/fs/ncpfs/ncp_fs.h
[]
> +#define ncp_dbg(level, fmt, ...) \
> +do { \
> + if (level >= DEBUG_NCP) \
> + pr_debug(fmt, ##__VA_ARGS__); \
> +} while (0)
Stupid thinko/typo self-nack. This should be:
if (DEBUG_NCP >= level)
next prev parent reply other threads:[~2014-02-10 0:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 22:48 [PATCH 0/5] ncpfs: Logging cleanups Joe Perches
2014-02-09 22:48 ` [PATCH 1/5] ncpfs: Add pr_fmt and convert printks to pr_<level> Joe Perches
2014-02-09 22:48 ` [PATCH 2/5] ncpfs: Convert DPRINTK/DDPRINTK to ncp_dbg Joe Perches
2014-02-10 0:53 ` Joe Perches [this message]
2014-02-09 22:48 ` [PATCH 3/5] ncpfs: Convert PPRINTK to ncp_vdbg Joe Perches
2014-02-09 22:48 ` [PATCH 4/5] ncpfs: Remove now unused PRINTK macro Joe Perches
2014-02-09 22:48 ` [PATCH 5/5] ncpfs: inode: Fix mismatch printk formats and arguments Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391993624.3178.11.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petr@vandrovec.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®