From: Joe Perches <joe@perches.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: gregkh@linuxfoundation.org, swetland@google.com,
john.stultz@linaro.org, rebecca@android.com, ccross@android.com,
ohaugan@codeaurora.org, romlem@google.com,
linux-kernel@vger.kernel.org, devel <devel@driverdev.osuosl.org>
Subject: Re: [PATCH] staging : ion : Fix some checkpatch warnings and an error
Date: Sun, 09 Feb 2014 22:07:04 -0800 [thread overview]
Message-ID: <1392012424.3178.23.camel@joe-AO722> (raw)
In-Reply-To: <81912500.jvGoQpGOq5@daeseok-laptop.cloud.net>
On Mon, 2014-02-10 at 14:56 +0900, Daeseok Youn wrote:
>
Hello.
> diff --git a/drivers/staging/android/ion/ion_priv.h b/drivers/staging/android/ion/ion_priv.h
[]
> - struct sg_table *(*map_dma) (struct ion_heap *heap,
> + struct sg_table * (*map_dma)(struct ion_heap *heap,
The message about space required after "struct sg_table *"
is a checkpatch defect. This is better as:
struct sg_table *(*map_dma)(struct ion_heap *heap, etc...)
I'll fix checkpatch in a little bit.
next prev parent reply other threads:[~2014-02-10 6:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 5:56 Daeseok Youn
2014-02-10 6:07 ` Joe Perches [this message]
2014-02-10 6:39 ` DaeSeok Youn
2014-02-10 23:59 ` [PATCH] checkpatch: Don't warn on some function pointer return styles Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392012424.3178.23.camel@joe-AO722 \
--to=joe@perches.com \
--cc=ccross@android.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ohaugan@codeaurora.org \
--cc=rebecca@android.com \
--cc=romlem@google.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®