From: Don Zickus <dzickus@redhat.com>
To: acme@ghostprotocols.net
Cc: LKML <linux-kernel@vger.kernel.org>,
jolsa@redhat.com, jmario@redhat.com, fowles@inreach.com,
eranian@google.com, Don Zickus <dzickus@redhat.com>
Subject: [PATCH 07/21] perf, callchain: Add generic callchain print handler for stdio
Date: Mon, 10 Feb 2014 12:29:02 -0500 [thread overview]
Message-ID: <1392053356-23024-8-git-send-email-dzickus@redhat.com> (raw)
In-Reply-To: <1392053356-23024-1-git-send-email-dzickus@redhat.com>
My initial implementation for rbtree sorting in the c2c tool does not use the
normal history elements. As a result, adding callchain support (which is
deeply integrated with history elements) is more challenging when trying to
display its output.
To make things simpler for myself (and to avoid rewriting the same code into
the c2c tool), I provided a generic interface that takes an unsorted callchain
list along with its total and relative sample size, and sorts it locally based
on period and calls the appropriate graph function (passing the correct sample
size).
This makes things easier because the c2c tool can be dumber and just collect
callchains and not worry about the magic needed to sort and display them
correctly.
Unfortunately, this is assuming a stdio output only and does not use the other
gui type outputs.
Regardless, this patch provides useful info for the tool right now. Tweaks and
recommendations for a better approach are welcomed. :-)
Signed-off-by: Don Zickus <dzickus@redhat.com>
---
tools/perf/ui/stdio/hist.c | 37 +++++++++++++++++++++++++++++++++++++
tools/perf/util/hist.h | 4 ++++
2 files changed, 41 insertions(+)
diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c
index 831fbb7..0a40f59 100644
--- a/tools/perf/ui/stdio/hist.c
+++ b/tools/perf/ui/stdio/hist.c
@@ -536,3 +536,40 @@ size_t events_stats__fprintf(struct events_stats *stats, FILE *fp)
return ret;
}
+
+size_t generic_entry_callchain__fprintf(struct callchain_root *unsorted_callchain,
+ u64 total_samples, u64 relative_samples,
+ int left_margin, FILE *fp)
+{
+ struct rb_root sorted_chain;
+ u64 min_callchain_hits;
+
+ if (!symbol_conf.use_callchain)
+ return 0;
+
+ min_callchain_hits = total_samples * (callchain_param.min_percent / 100);
+
+ callchain_param.sort(&sorted_chain, unsorted_callchain,
+ min_callchain_hits, &callchain_param);
+
+ switch (callchain_param.mode) {
+ case CHAIN_GRAPH_REL:
+ return callchain__fprintf_graph(fp, &sorted_chain, relative_samples,
+ left_margin);
+ break;
+ case CHAIN_GRAPH_ABS:
+ return callchain__fprintf_graph(fp, &sorted_chain, total_samples,
+ left_margin);
+ break;
+ case CHAIN_FLAT:
+ return callchain__fprintf_flat(fp, &sorted_chain, total_samples);
+ break;
+ case CHAIN_NONE:
+ break;
+ default:
+ pr_err("Bad callchain mode\n");
+ }
+
+ return 0;
+}
+
diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h
index a59743f..4fe5de5 100644
--- a/tools/perf/util/hist.h
+++ b/tools/perf/util/hist.h
@@ -111,6 +111,10 @@ size_t events_stats__fprintf(struct events_stats *stats, FILE *fp);
size_t hists__fprintf(struct hists *hists, bool show_header, int max_rows,
int max_cols, float min_pcnt, FILE *fp);
+size_t generic_entry_callchain__fprintf(struct callchain_root *unsorted_callchain,
+ u64 total_samples, u64 relative_samples,
+ int left_margin, FILE *fp);
+
void hists__filter_by_dso(struct hists *hists);
void hists__filter_by_thread(struct hists *hists);
void hists__filter_by_symbol(struct hists *hists);
--
1.7.11.7
next prev parent reply other threads:[~2014-02-10 17:57 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 17:28 [PATCH 00/21] perf, c2c: Add new tool to analyze cacheline contention on NUMA systems Don Zickus
2014-02-10 17:28 ` [PATCH 03/21] Revert "perf: Disable PERF_RECORD_MMAP2 support" Don Zickus
2014-02-10 17:28 ` [PATCH 04/21] perf, machine: Use map as success in ip__resolve_ams Don Zickus
2014-02-10 17:29 ` [PATCH 05/21] perf, session: Change header.misc dump from decimal to hex Don Zickus
2014-02-18 12:56 ` Jiri Olsa
2014-02-19 2:40 ` Don Zickus
2014-02-10 17:29 ` [PATCH 06/21] perf, stat: FIXME Stddev calculation is incorrect Don Zickus
2014-02-10 17:29 ` Don Zickus [this message]
2014-02-10 17:29 ` [PATCH 08/21] perf, c2c: Rework setup code to prepare for features Don Zickus
2014-02-18 13:02 ` Jiri Olsa
2014-02-19 2:45 ` Don Zickus
2014-02-10 17:29 ` [PATCH 09/21] perf, c2c: Add rbtree sorted on mmap2 data Don Zickus
2014-02-18 13:04 ` Jiri Olsa
2014-02-19 2:48 ` Don Zickus
2014-02-21 2:45 ` Don Zickus
2014-02-21 16:59 ` Jiri Olsa
2014-02-26 3:12 ` Don Zickus
2014-02-10 17:29 ` [PATCH 10/21] perf, c2c: Add stats to track data source bits and cpu to node maps Don Zickus
2014-02-18 13:05 ` Jiri Olsa
2014-02-19 2:51 ` Don Zickus
2014-02-10 17:29 ` [PATCH 11/21] perf, c2c: Sort based on hottest cache line Don Zickus
2014-02-10 17:29 ` [PATCH 12/21] perf, c2c: Display cacheline HITM analysis to stdout Don Zickus
2014-02-10 17:29 ` [PATCH 13/21] perf, c2c: Add callchain support Don Zickus
2014-02-18 13:07 ` Jiri Olsa
2014-02-19 2:54 ` Don Zickus
2014-02-10 17:29 ` [PATCH 14/21] perf, c2c: Output summary stats Don Zickus
2014-02-10 17:29 ` [PATCH 15/21] perf, c2c: Dump rbtree for debugging Don Zickus
2014-02-10 17:29 ` [PATCH 16/21] perf, c2c: Fixup tid because of perf map is broken Don Zickus
2014-02-10 17:29 ` [PATCH 17/21] perf, c2c: Add symbol count table Don Zickus
2014-02-18 13:09 ` Jiri Olsa
2014-02-19 2:56 ` Don Zickus
2014-02-10 17:29 ` [PATCH 18/21] perf, c2c: Add shared cachline summary table Don Zickus
2014-02-10 17:29 ` [PATCH 19/21] perf, c2c: Add framework to analyze latency and display summary stats Don Zickus
2014-02-10 17:29 ` [PATCH 20/21] perf, c2c: Add selected extreme latencies to output cacheline stats table Don Zickus
2014-02-10 17:29 ` [PATCH 21/21] perf, c2c: Add summary latency table for various parts of caches Don Zickus
2014-02-10 18:59 ` [PATCH 00/21] perf, c2c: Add new tool to analyze cacheline contention on NUMA systems Davidlohr Bueso
2014-02-10 19:17 ` Don Zickus
2014-02-10 19:18 ` [PATCH 01/21] perf c2c: Shared data analyser Don Zickus
2014-02-10 22:10 ` Davidlohr Bueso
2014-02-11 11:24 ` Jiri Olsa
2014-02-11 11:31 ` Arnaldo Carvalho de Melo
2014-02-11 13:54 ` Don Zickus
2014-02-11 14:36 ` Don Zickus
2014-02-11 15:41 ` Arnaldo Carvalho de Melo
2014-02-10 19:18 ` [PATCH 02/21] perf c2c: Dump raw records, decode data_src bits Don Zickus
2014-02-10 21:18 ` [PATCH 00/21] perf, c2c: Add new tool to analyze cacheline contention on NUMA systems Peter Zijlstra
2014-02-10 22:11 ` Don Zickus
2014-02-10 21:29 ` Peter Zijlstra
2014-02-10 22:20 ` Don Zickus
2014-02-10 22:21 ` Stephane Eranian
2014-02-11 7:14 ` Peter Zijlstra
2014-02-11 10:35 ` Stephane Eranian
2014-02-11 10:52 ` Peter Zijlstra
2014-02-11 10:58 ` Stephane Eranian
2014-02-11 11:02 ` Peter Zijlstra
2014-02-11 11:04 ` Stephane Eranian
2014-02-11 11:08 ` Peter Zijlstra
2014-02-11 11:08 ` Stephane Eranian
2014-02-11 11:14 ` Peter Zijlstra
2014-02-11 11:28 ` Stephane Eranian
2014-02-11 11:31 ` Peter Zijlstra
2014-02-11 11:51 ` Peter Zijlstra
2014-02-11 11:50 ` Arnaldo Carvalho de Melo
2014-02-11 12:09 ` Peter Zijlstra
2014-02-13 13:02 ` Jiri Olsa
2014-02-13 13:10 ` Stephane Eranian
[not found] ` <1392053356-23024-2-git-send-email-dzickus@redhat.com>
2014-02-18 12:52 ` [PATCH 01/21] perf c2c: Shared data analyser Jiri Olsa
2014-02-18 12:56 ` Arnaldo Carvalho de Melo
2014-02-19 2:42 ` Don Zickus
[not found] ` <1392053356-23024-3-git-send-email-dzickus@redhat.com>
2014-02-18 12:53 ` [PATCH 02/21] perf c2c: Dump raw records, decode data_src bits Jiri Olsa
2014-02-18 13:49 ` Arnaldo Carvalho de Melo
2014-02-19 3:04 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392053356-23024-8-git-send-email-dzickus@redhat.com \
--to=dzickus@redhat.com \
--cc=acme@ghostprotocols.net \
--cc=eranian@google.com \
--cc=fowles@inreach.com \
--cc=jmario@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®