From: Ben Hutchings <ben@decadent.org.uk>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Sander Eikelenboom <linux@eikelenboom.it>,
Dan Williams <dan.j.williams@intel.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Wei Liu <wei.liu2@citrix.com>,
Francois Romieu <romieu@fr.zoreil.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: 3.14-mw regression: rtl8169 WARNING: DMA-API: exceeded 7 overlapping mappings of pfn 55ebe
Date: Wed, 12 Feb 2014 22:52:42 +0000 [thread overview]
Message-ID: <1392245562.15615.29.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <1392154132.6615.91.camel@edumazet-glaptop2.roam.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]
On Tue, 2014-02-11 at 13:28 -0800, Eric Dumazet wrote:
[...]
> Incoming frames might be taken out of order-3 pages.
>
> With regular Ethernet frames, this is 21 frames per order-3 pages.
>
> ACTIVE_PFN_MAX_OVERLAP seems too small.
>
> Alternative would be to user order-0 only pages if CONFIG_DMA_API_DEBUG
> is set. Not sure if it works if PAGE_SIZE=66536 ....
Indeed, you can get a lot of packet buffers into a 64K page...
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index f589c9af8cbf..1b9995adfd29 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -1924,7 +1924,11 @@ static inline void __skb_queue_purge(struct sk_buff_head *list)
> kfree_skb(skb);
> }
>
> +#if defined(CONFIG_DMA_API_DEBUG)
> +#define NETDEV_FRAG_PAGE_MAX_ORDER 0
> +#else
> #define NETDEV_FRAG_PAGE_MAX_ORDER get_order(32768)
> +#endif
> #define NETDEV_FRAG_PAGE_MAX_SIZE (PAGE_SIZE << NETDEV_FRAG_PAGE_MAX_ORDER)
> #define NETDEV_PAGECNT_MAX_BIAS NETDEV_FRAG_PAGE_MAX_SIZE
>
That may be useful for debugging this particular problem, but please
don't make debugging options change behaviour like this.
Ben.
--
Ben Hutchings
If more than one person is responsible for a bug, no one is at fault.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2014-02-12 22:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-26 10:55 Sander Eikelenboom
2014-01-27 0:03 ` Francois Romieu
2014-01-29 3:06 ` Dan Williams
2014-02-06 11:36 ` Sander Eikelenboom
2014-02-06 13:09 ` Sander Eikelenboom
2014-02-06 14:26 ` Dan Williams
2014-02-06 14:27 ` Sander Eikelenboom
2014-02-06 19:12 ` Dan Williams
2014-02-07 10:21 ` Sander Eikelenboom
2014-02-11 19:56 ` Sander Eikelenboom
2014-02-11 21:28 ` Eric Dumazet
2014-02-11 22:53 ` Sander Eikelenboom
2014-02-12 22:52 ` Ben Hutchings [this message]
2014-02-12 2:07 ` Dan Williams
2014-02-12 4:17 ` Eric Dumazet
2014-02-12 14:56 ` Dan Williams
2014-02-13 20:14 ` Dan Williams
2014-02-13 21:49 ` Sander Eikelenboom
2014-02-25 17:45 ` Josh Boyer
2014-02-25 17:50 ` Dan Williams
2014-02-13 20:16 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392245562.15615.29.camel@deadeye.wl.decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=dan.j.williams@intel.com \
--cc=eric.dumazet@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@eikelenboom.it \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=wei.liu2@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®