Re: [PATCH 1/2] usb: host: remove USB_ARCH_HAS_?HCI

[Paul Bolle <pebolle@tiscali.nl>]

On Sun, 2014-02-16 at 15:02 -0500, Alan Stern wrote:
> On Sun, 16 Feb 2014, Paul Bolle wrote:
> > Note that the comment in this Kconfig file (that is also removed)
> > suggests to first remove the select statements for these symbols and
> > then the symbols themselves. But I think it makes more sense to first
> > delete these three symbols and then remove the selects statements (as
> > that is removing a second order effect). But it could just as well be
> > done with just one patch, I'd say.
> 
> There's a simple reason for not getting rid of the symbols first.  
> Doing it that way, as you did, leaves a window in which it's possible
> to select a non-existent symbol.  If that's not an error, it ought to
> be.

It is silently ignored. I've contemplated diving in the kconfig code to
see whether doing that could be made to trigger an error or, perhaps
better, a warning. I've not made up my mind yet.

It's trivial to merge these two patches, though. So feel free to ask me
to do that.

> Regardless, for both patches:
> 
> Acked-by: Alan Stern <stern@rowland.harvard.edu>

Thanks.


Paul Bolle