From: Kishon Vijay Abraham I <kishon@ti.com>
To: <gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>
Cc: <kishon@ti.com>
Subject: [PATCH 7/8] phy-core: Don't allow building phy-core as a module
Date: Mon, 17 Feb 2014 14:29:24 +0530 [thread overview]
Message-ID: <1392627565-1829-8-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1392627565-1829-1-git-send-email-kishon@ti.com>
From: Hans de Goede <hdegoede@redhat.com>
include/phy/phy.h has stub code in there for when building without the
phy-core enabled. This is useful for generic drivers such as ahci-platform,
ehci-platoform and ohci-platform which have support for driving an optional
phy passed to them through the devicetree.
Since on some boards this phy functionality is not needed, being able to
disable the phy subsystem without needing a lot of #ifdef magic in the
driver using it is quite useful.
However this breaks when the module using the phy subsystem is build-in and
the phy-core is not, which leads to the build failing with missing symbol
errors in the linking stage of the zImage.
Which leads to gems such as this being added to the Kconfig for achi_platform:
depends on GENERIC_PHY || !GENERIC_PHY
Rather then duplicating this code in a lot of places using the phy-core,
I believe it is better to simply not allow the phy-core to be built as a
module. The phy core is quite small and has no external dependencies, so
always building it in when enabling it should not be an issue.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Roger Quadros <rogerq@ti.com>
Acked-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/phy/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 79e3c70..c7a551c 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -5,7 +5,7 @@
menu "PHY Subsystem"
config GENERIC_PHY
- tristate "PHY Core"
+ bool "PHY Core"
help
Generic PHY support.
--
1.7.10.4
next prev parent reply other threads:[~2014-02-17 8:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 8:59 [GIT PULL 0/8] PHY subsystem fixes for 3.14-rc4 Kishon Vijay Abraham I
2014-02-17 8:59 ` [PATCH 1/8] usb: phy: twl4030-usb: Silence checkpatch warnings Kishon Vijay Abraham I
2014-02-18 20:11 ` Greg KH
2014-02-17 8:59 ` [PATCH 2/8] usb: phy: twl4030-usb: Remove redundant semicolon Kishon Vijay Abraham I
2014-02-18 20:11 ` Greg KH
2014-02-17 8:59 ` [PATCH 3/8] usb: phy: bcm-kona-usb2: Use PTR_ERR_OR_ZERO Kishon Vijay Abraham I
2014-02-18 20:11 ` Greg KH
2014-02-19 5:37 ` Kishon Vijay Abraham I
2014-02-17 8:59 ` [PATCH 4/8] phy,phy-bcm-kona-usb2.c: Add dependency on HAS_IOMEM Kishon Vijay Abraham I
2014-02-17 8:59 ` [PATCH 5/8] phy-core: phy_get: Leave error logging to the caller Kishon Vijay Abraham I
2014-02-17 8:59 ` [PATCH 6/8] phy-core: Don't propagate -ENOSUPP from phy_pm_runtime_get_sync to caller Kishon Vijay Abraham I
2014-02-17 8:59 ` Kishon Vijay Abraham I [this message]
2014-02-17 8:59 ` [PATCH 8/8] phy: let phy_provider_register be the last step in registering PHY Kishon Vijay Abraham I
2014-02-18 20:10 ` [GIT PULL 0/8] PHY subsystem fixes for 3.14-rc4 Greg KH
2014-02-19 5:42 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392627565-1829-8-git-send-email-kishon@ti.com \
--to=kishon@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome