From: Petr Mladek <pmladek@suse.cz>
To: Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Jiri Kosina <jkosina@suse.cz>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Petr Mladek <pmladek@suse.cz>
Subject: [PATCH 0/4] x86: Fix ftrace recovery when code modification failed
Date: Mon, 17 Feb 2014 16:22:49 +0100 [thread overview]
Message-ID: <1392650573-3390-1-git-send-email-pmladek@suse.cz> (raw)
Ftrace modifies function calls using Int3 breakpoints on x86. It patches
all functions in parallel to reduce the number of sync() calls. There is
a code that removes pending Int3 breakpoints when something goes wrong.
The recovery does not work on x86_64. I simulated an error in
ftrace_replace_code() and the system got rebooted.
This patch set fixes the recovery code, improves debugging of this
type of problem, and does some clean up.
BTW: It is an echo from the patch set that tried to use text_poke_bp()
instead of the ftrace-specific Int3 based patching code. Ftrace has
some specific restrictions. I did not find a way how to make the
universal text_poke_bp effective, safe, and clean to be usable
there.
The patch set is against linux/tip. Last commit is a5b3cca53c43c3ba7
(Merge tag 'v3.14-rc3')
Petr Mladek (4):
x86: Clean up remove_breakpoint() in ftrace code
x86: Fix ftrace patching recovery code to work on x86_64
x86: BUG when ftrace patching recovery fails
x86: Fix order of warning messages when ftrace modifies code
arch/x86/kernel/ftrace.c | 67 ++++++++++++++++++++++++------------------------
1 file changed, 34 insertions(+), 33 deletions(-)
--
1.8.4
next reply other threads:[~2014-02-17 15:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 15:22 Petr Mladek [this message]
2014-02-17 15:22 ` [PATCH 1/4] x86: Clean up remove_breakpoint() in ftrace code Petr Mladek
2014-02-17 15:22 ` [PATCH 2/4] x86: Fix ftrace patching recovery code to work on x86_64 Petr Mladek
2014-02-17 15:22 ` [PATCH 3/4] x86: BUG when ftrace patching recovery fails Petr Mladek
2014-02-17 15:22 ` [PATCH 4/4] x86: Fix order of warning messages when ftrace modifies code Petr Mladek
2014-03-06 23:19 ` Steven Rostedt
2014-03-07 8:43 ` Petr Mládek
2014-03-07 18:15 ` Steven Rostedt
2014-03-07 18:18 ` Steven Rostedt
2014-03-10 8:37 ` Petr Mládek
2014-03-10 12:50 ` Steven Rostedt
2014-02-21 4:23 ` [PATCH 0/4] x86: Fix ftrace recovery when code modification failed Steven Rostedt
2014-02-21 16:33 ` Petr Mládek
2014-02-21 18:01 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392650573-3390-1-git-send-email-pmladek@suse.cz \
--to=pmladek@suse.cz \
--cc=fweisbec@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®