From: Chase Southwood <chase.southwood@yahoo.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] Staging: comedi: addi-data: fix brace-related coding style issues in hwdrv_apci035.c
Date: Tue, 18 Feb 2014 17:25:59 -0800 (PST) [thread overview]
Message-ID: <1392773159.94094.YahooMailNeo@web164004.mail.gq1.yahoo.com> (raw)
In-Reply-To: <20140218105944.GM26722@mwanda>
>On Tuesday, February 18, 2014 5:00 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>>On Mon, Feb 17, 2014 at 12:45:07PM -0800, Chase Southwood wrote:
>>>On Monday, February 17, 2014 7:16 AM, Ian Abbott <abbotti@mev.co.uk> wrote:
>>>>
>>>>On 2014-02-16 08:40, Chase Southwood wrote:
>>>> This patch for hwdrv_apci035 removes some unneeded braces, and moves some
>>>> improperly placed braces to the correct position, as found by checkpatch.
>>>> It also removes a commented out if-statement that I found whilst cleaning
>>>> braces that is identical to another un-commented if-statement directly
>>>> above it, so it is just added clutter and so we can delete it to clean up
>>>> further.
>>>>
>>>> Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
>>>> ---
>>>> So I decided to venture into addi-data today and found that most of the
>>>> files in there are very messy from a style standpoint. This is the first
>>>> (of probably a few) patchsets to try and clean those files up a bit. I
>>>> hope that this will be helpful!
>>>>
>>>Quite a few have been cleaned up extensively by Hartley, but they needed
>>>more extensive changes than clean-ups due to them trying to handle
>>>things differently to the normal comedi way of doing things.
>>
>>Oh, I see. Makes perfect sense. Well like I said, if cleaning them
>>up a bit will help make reworking them any easier or seems like useful
>>work, I'd be happy to continue making them a little easier on the
>>eyes!
>
>Ian acked your patch already... If you want to clean these up then go
>for it. There is no reason Hartley should have to do all the work.
>
>But consider doing more "extensive" cleanups. Instead of just shifting
>the comments over in [patch 2/4] you could change the format to kernel
>style. Newbies are too timid. Look through the work that Hartley has
>done and try copy it.
>
>regards,
>dan carpenter
Dan,
I appreciate the feedback on my contributions. I will try to do more extensive cleaning because I want to help out as best as I can.
Thanks,
Chase
prev parent reply other threads:[~2014-02-19 1:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 8:40 Chase Southwood
2014-02-16 8:41 ` [PATCH 2/4] Staging: comedi: addi-data: cleanup comments " Chase Southwood
2014-02-17 13:16 ` Ian Abbott
2014-02-16 8:41 ` [PATCH 3/4] Staging: comedi: addi-data: convert printk() to dev_err() Chase Southwood
2014-02-17 13:17 ` Ian Abbott
2014-02-17 20:47 ` Chase Southwood
2014-02-18 6:34 ` [PATCH 3/4 v2] " Chase Southwood
2014-02-18 10:52 ` Ian Abbott
2014-02-16 8:41 ` [PATCH 4/4] Staging: comedi: addi-data: do not initialize statics to 0 in hwdrv_apci035.c Chase Southwood
2014-02-17 13:22 ` Ian Abbott
2014-02-17 13:16 ` [PATCH 1/4] Staging: comedi: addi-data: fix brace-related coding style issues " Ian Abbott
2014-02-17 20:45 ` Chase Southwood
2014-02-18 10:59 ` Dan Carpenter
2014-02-19 1:25 ` Chase Southwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392773159.94094.YahooMailNeo@web164004.mail.gq1.yahoo.com \
--to=chase.southwood@yahoo.com \
--cc=abbotti@mev.co.uk \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®