From: Lei Wen <leiwen@marvell.com>
To: <peterz@infradead.org>, <mingo@redhat.com>,
<preeti.lkml@gmail.com>, <daniel.lezcano@linaro.org>,
<viresh.kumar@linaro.org>, <xjian@marvell.com>,
<leiwen@marvell.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] sched: keep quiescent cpu out of idle balance loop
Date: Wed, 19 Feb 2014 13:20:30 +0800 [thread overview]
Message-ID: <1392787230-17986-1-git-send-email-leiwen@marvell.com> (raw)
Since cpu which is put into quiescent mode, would remove itself
from kernel's sched_domain. So we could use search sched_domain
method to check whether this cpu don't want to be disturbed as
idle load balance would send IPI to it.
Signed-off-by: Lei Wen <leiwen@marvell.com>
---
kernel/sched/fair.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 235cfa7..14230ae 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6783,6 +6783,8 @@ out_unlock:
* - When one of the busy CPUs notice that there may be an idle rebalancing
* needed, they will kick the idle load balancer, which then does idle
* load balancing for all the idle CPUs.
+ * - exclude those cpus not inside current call_cpu's sched_domain, so that
+ * those isolated cpu could be kept in their quisecnt mode.
*/
static struct {
cpumask_var_t idle_cpus_mask;
@@ -6792,10 +6794,16 @@ static struct {
static inline int find_new_ilb(void)
{
- int ilb = cpumask_first(nohz.idle_cpus_mask);
+ int ilb;
+ int cpu = smp_processor_id();
+ struct sched_domain *tmp;
- if (ilb < nr_cpu_ids && idle_cpu(ilb))
- return ilb;
+ for_each_domain(cpu, tmp) {
+ ilb = cpumask_first_and(nohz.idle_cpus_mask,
+ sched_domain_span(tmp));
+ if (ilb < nr_cpu_ids && idle_cpu(ilb))
+ return ilb;
+ }
return nr_cpu_ids;
}
--
1.8.3.2
next reply other threads:[~2014-02-19 5:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 5:20 Lei Wen [this message]
2014-02-19 9:04 ` Peter Zijlstra
2014-02-20 2:42 ` Lei Wen
2014-02-20 8:50 ` Peter Zijlstra
2014-02-20 9:15 ` Lei Wen
2014-02-20 9:17 ` Lei Wen
2014-02-20 12:04 ` Peter Zijlstra
2014-02-20 12:23 ` Peter Zijlstra
2014-02-21 2:23 ` [PATCH v2] " Lei Wen
2014-02-21 5:51 ` Mike Galbraith
2014-02-21 7:28 ` Lei Wen
2014-02-21 8:34 ` Mike Galbraith
2014-02-21 9:15 ` [PATCH v3] " Lei Wen
2014-02-21 9:41 ` Mike Galbraith
2014-02-21 9:15 ` [PATCH v2] " Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392787230-17986-1-git-send-email-leiwen@marvell.com \
--to=leiwen@marvell.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=preeti.lkml@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=xjian@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®