From: Alan Cox <alan@linux.intel.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/tty/serial: deal with 8250_core.c uninitialized warning for good
Date: Wed, 19 Feb 2014 20:51:23 +0000 [thread overview]
Message-ID: <1392843083.11798.74.camel@acox1-desk.ger.corp.intel.com> (raw)
In-Reply-To: <1392840013-15957-1-git-send-email-paul.gortmaker@windriver.com>
On Wed, 2014-02-19 at 15:00 -0500, Paul Gortmaker wrote:
> Every couple of months, someone sends a patch to fix:
>
> drivers/tty/serial/8250/8250_core.c: In function 'serial_unlink_irq_chain':
> drivers/tty/serial/8250/8250_core.c:1712:2: warning: 'i' may be used uninitialized in this function [-Wuninitialized]
>
> and they in turn get a NACK for their efforts, and are told that
> their compiler is broken. This has been going on since at least
> the year 2008: https://lkml.org/lkml/2008/11/24/433
>
> Lets add a comment, so that subsequent patches don't get as far as
> the maintainers or the mailing lists.
Are people still using gcc variants that get this wrong ?
Fine by me.
Acked-by: Alan Cox <alan@linux.intel.com>
next prev parent reply other threads:[~2014-02-19 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 20:00 Paul Gortmaker
2014-02-19 20:06 ` Jiri Slaby
2014-02-19 20:51 ` Alan Cox [this message]
2014-02-19 21:19 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392843083.11798.74.camel@acox1-desk.ger.corp.intel.com \
--to=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®