mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: "John Stultz" <john.stultz@linaro.org>,
	"Greg KH" <gregkh@linuxfoundation.org>,
	"Colin Cross" <ccross@android.com>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Serban Constantinescu" <serban.constantinescu@arm.com>,
	"Android Kernel Team" <kernel-team@android.com>
Subject: [PATCH 3/3] staging: binder: Improve Kconfig entry for ANDROID_BINDER_IPC_32BIT
Date: Fri, 21 Feb 2014 12:43:34 -0800	[thread overview]
Message-ID: <1393015414-12499-4-git-send-email-john.stultz@linaro.org> (raw)
In-Reply-To: <1393015414-12499-1-git-send-email-john.stultz@linaro.org>

Add a more clear explanation of the option in the prompt, and
make the config depend on ANDROID_BINDER_IPC being selected.

Also sets the default to y, which matches AOSP.

Cc: Greg KH <gregkh@linuxfoundation.org>
Cc: Colin Cross <ccross@android.com>
Cc: Arve Hjønnevåg <arve@android.com>
Cc: Serban Constantinescu <serban.constantinescu@arm.com>
Cc: Android Kernel Team <kernel-team@android.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
 drivers/staging/android/Kconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
index 3559690..1c779ef 100644
--- a/drivers/staging/android/Kconfig
+++ b/drivers/staging/android/Kconfig
@@ -21,8 +21,9 @@ config ANDROID_BINDER_IPC
 	  between said processes.
 
 config ANDROID_BINDER_IPC_32BIT
-	bool "Use old 32-bit binder api"
-	depends on !64BIT
+	bool "Use old (Android 4.4 and earlier) 32-bit binder API"
+	depends on !64BIT && ANDROID_BINDER_IPC
+	default y
 	---help---
 	  The Binder API has been changed to support both 32 and 64bit
 	  applications in a mixed environment.
-- 
1.8.3.2


      parent reply	other threads:[~2014-02-21 20:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21 20:43 [PATCH 0/3] Binder ABI updates for 64bit systems for staging-next John Stultz
2014-02-21 20:43 ` [PATCH 1/3] staging: binder: Fix ABI for 64bit Android John Stultz
2014-02-21 20:43 ` [PATCH 2/3] staging: binder: Support concurrent 32 bit and 64 bit processes John Stultz
2014-02-21 20:59   ` Arve Hjønnevåg
2014-02-21 21:29     ` John Stultz
2014-02-21 21:56       ` Arve Hjønnevåg
2014-02-21 22:04         ` John Stultz
2014-02-21 22:10           ` Arve Hjønnevåg
2014-02-21 22:35             ` John Stultz
2014-02-21 20:43 ` John Stultz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393015414-12499-4-git-send-email-john.stultz@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=arve@android.com \
    --cc=ccross@android.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=serban.constantinescu@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome