From: minyard@acm.org
To: OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Russ Anderson <rja@sgi.com>,
Matthew Garrett <matthew.garrett@nebula.com>,
lenb@kernel.org, rjw@rjwysocki.net, linux-acpi@vger.kernel.org
Subject: [PATCH 3/3] Change ACPI IPMI support to "default y"
Date: Sun, 23 Feb 2014 20:23:36 -0600 [thread overview]
Message-ID: <1393208616-16500-4-git-send-email-minyard@acm.org> (raw)
In-Reply-To: <1393208616-16500-1-git-send-email-minyard@acm.org>
From: Matthew Garrett <matthew.garrett@nebula.com>
The ACPI IPMI driver implements IPMI operation region support for the ACPI
core. Systems that declare ACPI operation regions may reference them at any
time, including during kernel initialisation. These accesses will fail
unless the ACPI IPMI driver is present, and undesirable system behaviour
may result. Set the default to Y in order to encourage distributions and
users to configure kernels to avoid awkward surprises.
Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
---
drivers/acpi/Kconfig | 2 +-
drivers/char/ipmi/Kconfig | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 4770de5..0e6aab9 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -162,7 +162,7 @@ config ACPI_PROCESSOR
config ACPI_IPMI
tristate "IPMI"
depends on IPMI_SI
- default n
+ default y
help
This driver enables the ACPI to access the BMC controller. And it
uses the IPMI request/response message to communicate with BMC
diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
index 8e14360..5eb7e85 100644
--- a/drivers/char/ipmi/Kconfig
+++ b/drivers/char/ipmi/Kconfig
@@ -5,6 +5,7 @@
menuconfig IPMI_HANDLER
tristate 'IPMI top-level message handler'
depends on HAS_IOMEM
+ default y if ACPI
help
This enables the central IPMI message handler, required for IPMI
to work.
@@ -45,6 +46,7 @@ config IPMI_DEVICE_INTERFACE
config IPMI_SI
tristate 'IPMI System Interface handler'
+ default y if ACPI
help
Provides a driver for System Interfaces (KCS, SMIC, BT).
Currently, only KCS and SMIC are supported. If
--
1.8.3.1
next prev parent reply other threads:[~2014-02-24 2:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 2:23 [PATCH 0/3] ipmi: Cleanups for allowing IPMI support to always be "y" minyard
2014-02-24 2:23 ` [PATCH 1/3] ipmi: Turn off default probing of interfaces minyard
2014-02-24 16:53 ` Dmitry Torokhov
2014-02-24 16:55 ` Matthew Garrett
2014-02-24 16:57 ` Corey Minyard
2014-02-24 2:23 ` [PATCH 2/3] ipmi: Turn off all activity on an idle ipmi interface minyard
2014-02-24 16:57 ` Dmitry Torokhov
2014-02-24 17:08 ` Corey Minyard
2014-02-24 2:23 ` minyard [this message]
2014-02-24 12:43 ` [PATCH 0/3] ipmi: Cleanups for allowing IPMI support to always be "y" Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393208616-16500-4-git-send-email-minyard@acm.org \
--to=minyard@acm.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=rja@sgi.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®