From: Joe Perches <joe@perches.com>
To: David Roddick <dgroddick@gmail.com>
Cc: gregkh@linuxfoundation.org, abbotti@mev.co.uk,
hsweeten@visionengravers.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: Fix coding style issue in poc.c
Date: Mon, 24 Feb 2014 00:53:35 -0800 [thread overview]
Message-ID: <1393232015.11020.25.camel@joe-AO722> (raw)
In-Reply-To: <1393231142-2227-1-git-send-email-dgroddick@gmail.com>
On Mon, 2014-02-24 at 19:39 +1100, David Roddick wrote:
> This is a patch to remove unneccessary space after function pointer name found with checkpatch.pl
A few comments:
Please wrap your commit message to 70 columns or so.
There is 1 c in unnecessary.
The "This is a patch to " bit isn't particularly useful in
the commit log, neither is the "found with checkpatch.pl".
> diff --git a/drivers/staging/comedi/drivers/poc.c b/drivers/staging/comedi/drivers/poc.c
[]
> @@ -36,15 +36,15 @@ Configuration options:
[]
> - int (*winsn) (struct comedi_device *, struct comedi_subdevice *,
> + int (*winsn)(struct comedi_device *, struct comedi_subdevice *,
> struct comedi_insn *, unsigned int *);
Please wrap multi-line definitions lines like:
int (*winsn)(struct comedi_device *, struct comedi_subdevice *,
struct comedi_insn *, unsigned int *);
Ideally, these arguments would have some descriptive names
too.
prev parent reply other threads:[~2014-02-24 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 8:39 David Roddick
2014-02-24 8:53 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393232015.11020.25.camel@joe-AO722 \
--to=joe@perches.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=dgroddick@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®