From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: mingo@kernel.org, peterz@infradead.org, tglx@linutronix.de,
rjw@rjwysocki.net
Cc: nicolas.pitre@linaro.org, preeti@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 5/5] idle: Add more comments to the code
Date: Tue, 25 Feb 2014 09:08:53 +0100 [thread overview]
Message-ID: <1393315733-32321-5-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1393315733-32321-1-git-send-email-daniel.lezcano@linaro.org>
The idle main function is a complex and a critical function. Added more
comments to the code.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Nicolas Pitre <nico@linaro.org>
---
Changelog:
V2:
* fixed typo in comment
---
kernel/sched/idle.c | 43 +++++++++++++++++++++++++++++++++++++++++--
1 file changed, 41 insertions(+), 2 deletions(-)
Index: cpuidle-next/kernel/sched/idle.c
===================================================================
--- cpuidle-next.orig/kernel/sched/idle.c
+++ cpuidle-next/kernel/sched/idle.c
@@ -76,20 +76,48 @@ static int cpuidle_idle_call(void)
int next_state, entered_state;
bool broadcast;
+ /*
+ * Check if the idle task must be rescheduled. If it is the
+ * case, exit the function after re-enabling the local irq and
+ * set again the polling flag
+ */
if (current_clr_polling_and_test()) {
local_irq_enable();
__current_set_polling();
return 0;
}
+ /*
+ * During the idle period, stop measuring the disabled irqs
+ * critical sections latencies
+ */
stop_critical_timings();
+
+ /*
+ * Tell the RCU framework we are entering an idle section,
+ * so no more rcu read side critical sections and one more
+ * step to the grace period
+ */
rcu_idle_enter();
+ /*
+ * Check if the cpuidle framework is ready, otherwise fallback
+ * to the default arch specific idle method
+ */
if (cpuidle_enabled(drv, dev) == 0) {
- /* ask the governor for the next state */
+ /*
+ * Ask the governor to choose an idle state it thinks
+ * it is convenient to go to. There is *always* a
+ * convenient idle state
+ */
next_state = cpuidle_select(drv, dev);
+ /*
+ * The idle task must be scheduled, it is pointless to
+ * go to idle, just update no idle residency and get
+ * out of this function
+ */
if (current_clr_polling_and_test()) {
dev->last_residency = 0;
entered_state = next_state;
@@ -104,7 +132,13 @@ static int cpuidle_idle_call(void)
clockevents_notify(
CLOCK_EVT_NOTIFY_BROADCAST_ENTER,
&dev->cpu);
-
+ /*
+ * Enter the idle state previously returned by
+ * the governor decision. This function will
+ * block until an interrupt occurs and will
+ * take care of re-enabling the local
+ * interrupts
+ */
entered_state = cpuidle_enter(drv, dev, next_state);
if (broadcast)
@@ -164,6 +198,11 @@ static void cpu_idle_loop(void)
if (cpu_idle_force_poll || tick_check_broadcast_expired())
cpu_idle_poll();
else
+ /*
+ * It is up to the underlying
+ * functions to enable the local
+ * interrupts again
+ */
cpuidle_idle_call();
arch_cpu_idle_exit();
next prev parent reply other threads:[~2014-02-25 8:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 8:08 [PATCH V3 1/5] idle/cpuidle: Split cpuidle_idle_call main function into smaller functions Daniel Lezcano
2014-02-25 8:08 ` [PATCH V3 2/5] cpuidle/idle: Move the cpuidle_idle_call function to idle.c Daniel Lezcano
2014-02-25 8:08 ` [PATCH V3 3/5] idle: Reorganize the idle loop Daniel Lezcano
2014-02-25 8:08 ` [PATCH V3 4/5] idle: Move idle conditions in cpuidle_idle main function Daniel Lezcano
2014-02-25 8:08 ` Daniel Lezcano [this message]
2014-02-28 12:01 ` [PATCH V3 1/5] idle/cpuidle: Split cpuidle_idle_call main function into smaller functions Preeti U Murthy
2014-02-28 12:56 ` Peter Zijlstra
2014-02-28 15:31 ` Daniel Lezcano
2014-03-03 7:48 ` [PATCH V4 " Daniel Lezcano
2014-03-03 7:48 ` [PATCH V4 2/5] cpuidle/idle: Move the cpuidle_idle_call function to idle.c Daniel Lezcano
2014-03-11 12:37 ` [tip:sched/idle] " tip-bot for Daniel Lezcano
2014-03-03 7:48 ` [PATCH V4 3/5] idle: Reorganize the idle loop Daniel Lezcano
2014-03-11 12:37 ` [tip:sched/idle] sched/idle: " tip-bot for Daniel Lezcano
2014-03-03 7:48 ` [PATCH V4 4/5] idle: Move idle conditions in cpuidle_idle main function Daniel Lezcano
2014-03-11 12:37 ` [tip:sched/idle] sched/idle: " tip-bot for Daniel Lezcano
2014-03-03 7:48 ` [PATCH V4 5/5] idle: Add more comments to the code Daniel Lezcano
2014-03-11 12:37 ` [tip:sched/idle] sched/idle: " tip-bot for Daniel Lezcano
2014-03-11 12:37 ` [tip:sched/idle] idle/cpuidle: Split cpuidle_idle_call main function into smaller functions tip-bot for Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393315733-32321-5-git-send-email-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=peterz@infradead.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome