mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	mtosatti@redhat.com, gleb@kernel.org, jan.kiszka@siemens.com
Subject: Re: [PATCH 0/4] KVM: x86: Let the guest write to multiple debug registers with one vmexit
Date: Wed, 26 Feb 2014 10:00:40 -0700	[thread overview]
Message-ID: <1393434040.18087.2.camel@ul30vt.home> (raw)
In-Reply-To: <1393429753-20857-1-git-send-email-pbonzini@redhat.com>

On Wed, 2014-02-26 at 16:49 +0100, Paolo Bonzini wrote:
> Alex Williamson reported that a Windows game does something weird that
> makes the guest save and restore debug registers on each context switch.
> This cause several hundred thousands vmexits per second, and basically
> cuts performance in half when running under KVM.
> 
> However, when not running in guest-debug mode, the guest controls the
> debug registers and having to take an exit for each DR access is a waste
> of time.  We just need one vmexit to load any stale values of DR0-DR6,
> and then we can let the guest run freely.  On the next vmexit (whatever
> the reason) we will read out whatever changes the guest made to the
> debug registers.
> 
> On top of this, we can implement SVM support and let nested guests run
> with dirty debug registers too.
> 
> Paolo Bonzini (4):
>   KVM: vmx: we do rely on loading DR7 on entry
>   KVM: x86: change vcpu->arch.switch_db_regs to a bit mask
>   KVM: x86: Allow the guest to run with dirty debug registers
>   KVM: vmx: Allow the guest to run with dirty debug registers
> 
>  arch/x86/include/asm/kvm_host.h |  8 ++++++-
>  arch/x86/kvm/vmx.c              | 48 +++++++++++++++++++++++++++++++++++++----
>  arch/x86/kvm/x86.c              | 29 +++++++++++++++++++++++--
>  3 files changed, 78 insertions(+), 7 deletions(-)
> 

I see a slightly better than 100% improvement in the frame rate in
Borderlands2 running in a VM with assigned Nvidia GPU with this series.

Tested-by: Alex Williamson <alex.williamson@redhat.com>


      parent reply	other threads:[~2014-02-26 17:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26 15:49 Paolo Bonzini
2014-02-26 15:49 ` [PATCH 1/4] KVM: vmx: we do rely on loading DR7 on entry Paolo Bonzini
2014-02-26 15:49 ` [PATCH 2/4] KVM: x86: change vcpu->arch.switch_db_regs to a bit mask Paolo Bonzini
2014-02-26 15:49 ` [PATCH 3/4] KVM: x86: Allow the guest to run with dirty debug registers Paolo Bonzini
2014-02-26 15:49 ` [PATCH 4/4] KVM: vmx: " Paolo Bonzini
2014-02-27 11:25   ` Jan Kiszka
2014-02-27 12:54     ` Paolo Bonzini
2014-02-26 17:00 ` Alex Williamson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393434040.18087.2.camel@ul30vt.home \
    --to=alex.williamson@redhat.com \
    --cc=gleb@kernel.org \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®