mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Tom Rini <trini@ti.com>
Cc: Josh Triplett <josh@joshtriplett.org>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] checkpatch.pl: Add warning for new __packed additions
Date: Wed, 26 Feb 2014 14:04:16 -0800	[thread overview]
Message-ID: <1393452256.24588.5.camel@joe-AO722> (raw)
In-Reply-To: <530C8D00.8070606@ti.com>

On Tue, 2014-02-25 at 07:30 -0500, Tom Rini wrote:
> The only intentional differences we have today are adding debug/printf
> to the list of log functions

That seems fine and trivial to keep current.

> and pointing people at boards.cfg not
> CHECKPATCH in MAINTAINERS,

That seems wrong.

The idea of that message is to fix defects in checkpatch,
not any other code.

Maybe that could be reworded to
"See the CHECKPATCH entry in the MAINTAINERS file of linux git"
or some such.

>  so I can re-sync us no problem as, yup, we're
> about a year out of date there.  Oh and I see now someone snuck in a
> check for whitespace before semi-colon to catch 'return 0 ;' which I'll
> check real quick isn't something already caught and if not post that as
> well.

Does anyone know of other projects that use checkpatch?



  reply	other threads:[~2014-02-26 22:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24 20:38 Tom Rini
2014-02-24 21:00 ` Joe Perches
2014-02-24 21:11   ` Tom Rini
2014-02-24 21:28     ` Joe Perches
2014-02-24 21:52       ` Tom Rini
2014-02-24 22:02         ` Joe Perches
2014-02-24 22:04           ` Tom Rini
2014-02-24 22:08             ` Joe Perches
2014-02-24 22:20               ` Tom Rini
2014-02-24 22:31                 ` Joe Perches
2014-02-24 22:43                   ` Tom Rini
2014-02-25  5:23                     ` Joe Perches
2014-02-25 12:30                       ` Tom Rini
2014-02-26 22:04                         ` Joe Perches [this message]
2014-02-27 20:33                           ` Tom Rini
2014-02-25  8:56             ` Heiko Carstens
2014-02-24 21:31 ` josh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393452256.24588.5.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trini@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®