From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751862AbaB1KDX (ORCPT ); Fri, 28 Feb 2014 05:03:23 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:64678 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751198AbaB1KCF (ORCPT ); Fri, 28 Feb 2014 05:02:05 -0500 X-AuditID: cbfec7f4-b7f796d000005a13-64-53105e98b090 From: Krzysztof Kozlowski To: Sangbeom Kim , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Tomasz Figa , Yadwinder Singh Brar , Krzysztof Kozlowski Subject: [PATCH 1/3] regulator: s2mps11: Don't store registered regulators in state container Date: Fri, 28 Feb 2014 11:01:48 +0100 Message-id: <1393581710-17754-2-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1393581710-17754-1-git-send-email-k.kozlowski@samsung.com> References: <1393581710-17754-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphluLIzCtJLcpLzFFi42I5/e/4Zd0ZcQLBBnfa9C02zljPajH14RM2 i9cvDC3ONr1ht/h2pYPJ4vKuOWwWM87vY7JYe+Quu8XFFV+YLNbPeM1iMWf6OyYHbo+ds+6y e2xa1cnm0bdlFaPH501yASxRXDYpqTmZZalF+nYJXBkTJ7exFyzkqdjcdpClgbGLq4uRk0NC wERiSc8hNghbTOLCvfVANheHkMBSRokbt1dBOX1MEscnbWMBqWITMJbYvHwJWEJEYCOjxMH9 h1lBHGaBmUwSf24+YAKpEhaIl5g26RmYzSKgKrH67TQwm1fAXWJdO9B2Rg6gfQoScybZgJic Ah4SF9cYglQIAVVc2XuXeQIj7wJGhlWMoqmlyQXFSem5hnrFibnFpXnpesn5uZsYISH3ZQfj 4mNWhxgFOBiVeHgnePIHC7EmlhVX5h5ilOBgVhLhzXMXCBbiTUmsrEotyo8vKs1JLT7EyMTB KdXA6MbU1/Fu6c6yc2lqMY9OHTqwReVkJvMii//+mVeEDj8qqznI+7ePfZFxtAXHgldZlUaf bJ+vC2XQEojr462LD5jfEG7QV/xuotykmymzupxbmLwZzvU8Kr3rV2t2K6pnw6OTU950XSvx tpl9R+WBC9cLgY3FSkffLE9P/nn/5nQhUZNPfG6xSizFGYmGWsxFxYkAyxlu7hcCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Regulators registered by devm_regulator_register() do not have to be stored in state container because they are never dereferenced later. The array of regulator_dev can be safely removed from state container. Signed-off-by: Krzysztof Kozlowski --- drivers/regulator/s2mps11.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index cd0b9e35a56d..3647d590b962 100644 --- a/drivers/regulator/s2mps11.c +++ b/drivers/regulator/s2mps11.c @@ -28,8 +28,6 @@ #define S2MPS11_REGULATOR_CNT ARRAY_SIZE(regulators) struct s2mps11_info { - struct regulator_dev *rdev[S2MPS11_REGULATOR_MAX]; - int ramp_delay2; int ramp_delay34; int ramp_delay5; @@ -439,6 +437,8 @@ common_reg: config.regmap = iodev->regmap_pmic; config.driver_data = s2mps11; for (i = 0; i < S2MPS11_REGULATOR_MAX; i++) { + struct regulator_dev *regulator; + if (!reg_np) { config.init_data = pdata->regulators[i].initdata; config.of_node = pdata->regulators[i].reg_node; @@ -447,10 +447,10 @@ common_reg: config.of_node = rdata[i].of_node; } - s2mps11->rdev[i] = devm_regulator_register(&pdev->dev, + regulator = devm_regulator_register(&pdev->dev, ®ulators[i], &config); - if (IS_ERR(s2mps11->rdev[i])) { - ret = PTR_ERR(s2mps11->rdev[i]); + if (IS_ERR(regulator)) { + ret = PTR_ERR(regulator); dev_err(&pdev->dev, "regulator init failed for %d\n", i); return ret; -- 1.7.9.5