mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kirill Tkhai <ktkhai@parallels.com>
To: <linux-kernel@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, <tkhai@yandex.ru>
Subject: Re: [PATCH]sched/core: Return possibility to set RT and DL classes back
Date: Fri, 28 Feb 2014 14:50:43 +0400	[thread overview]
Message-ID: <1393584643.3522.5.camel@tkhai> (raw)
In-Reply-To: <1393496657.3522.3.camel@tkhai>

Thomas, have you seen this?

Nothing works at the moment:

now

   21 root      20   0     0    0    0 S  0.0  0.0   0:00.00 watchdog/3                                                                                                                                            
   16 root      20   0     0    0    0 S  0.0  0.0   0:00.00 watchdog/2                                                                                                                                            
   11 root      20   0     0    0    0 S  0.0  0.0   0:00.00 watchdog/1                                                                                                                                            
   10 root      20   0     0    0    0 S  0.0  0.0   0:00.00 watchdog/0

   22 root      20   0     0    0    0 S  0.0  0.0   0:00.00 migration/3                                                                                                                                           
   17 root      20   0     0    0    0 S  0.0  0.0   0:00.00 migration/2                                                                                                                                           
   12 root      20   0     0    0    0 S  0.0  0.0   0:00.04 migration/1                                                                                                                                           
    9 root      20   0     0    0    0 S  0.0  0.0   0:00.20 migration/0

with fix

   21 root      RT   0     0    0    0 S  0.0  0.0   0:00.00 watchdog/3         
   16 root      RT   0     0    0    0 S  0.0  0.0   0:00.00 watchdog/2         
   11 root      RT   0     0    0    0 S  0.0  0.0   0:00.00 watchdog/1         
   10 root      RT   0     0    0    0 S  0.0  0.0   0:00.00 watchdog/0

   22 root      RT   0     0    0    0 S  0.0  0.0   0:00.00 migration/3                                                                                                                                           
   17 root      RT   0     0    0    0 S  0.0  0.0   0:00.03 migration/2                                                                                                                                           
   12 root      RT   0     0    0    0 S  0.0  0.0   0:00.00 migration/1                                                                                                                                           
    9 root      RT   0     0    0    0 S  0.0  0.0   0:00.24 migration/0

В Чт, 27/02/2014 в 14:24 +0400, Kirill Tkhai пишет:
> [PATCH]sched/core: Return possibility to set RT and DL classes back
> 
> I found that it's impossible to set RT policy for tasks at the moment.
> 
> This is regression after commit [sched: Consider pi boosting in setscheduler()]
> 				[c365c292d05908c6ea6f32708f331e21033fe71d     ]
> Fix that.
> 
> Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
> CC: Thomas Gleixner <tglx@linutronix.de>
> CC: Peter Zijlstra <peterz@infradead.org>
> CC: Ingo Molnar <mingo@redhat.com>
> ---
>  kernel/sched/core.c | 4 ++++
>  1 file changed, 4 insertions(+)
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 84b23ce..30cf9ad 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -3193,6 +3193,10 @@ static void __setscheduler_params(struct task_struct *p,
>  	 * getparam()/getattr() don't report silly values for !rt tasks.
>  	 */
>  	p->rt_priority = attr->sched_priority;
> +
> +	p->normal_prio = normal_prio(p);
> +	p->prio = rt_mutex_getprio(p);
> +
>  	set_load_weight(p);
>  }
>  
> 



  reply	other threads:[~2014-02-28 10:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27 10:24 Kirill Tkhai
2014-02-28 10:50 ` Kirill Tkhai [this message]
2014-03-01 18:18   ` Juri Lelli
2014-03-03  9:35     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393584643.3522.5.camel@tkhai \
    --to=ktkhai@parallels.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tkhai@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome