mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	Namhyung Kim <namhyung@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>
Subject: [PATCHSET 00/13] perf tools: Update on filtered entries' percentage output (v6)
Date: Mon,  3 Mar 2014 10:14:01 +0900	[thread overview]
Message-ID: <1393809254-4480-1-git-send-email-namhyung@kernel.org> (raw)

Hello,

I added --percentage option to perf report to control display of
percentage of filtered entries.

 usage: perf report [<options>]

        --percentage <relative|absolute>
                          how to display percentage of filtered entries

"relative" means it's relative to filtered entries only so that the
sum of shown entries will be always 100%.  "absolute" means it retains
original value before and after the filter applied.  In patch 8/8, I
made the "absolute" as default since it makes more sense IMHO.
    
      $ perf report -s comm
      # Overhead       Command
      # ........  ............
      #
          74.19%           cc1
           7.61%           gcc
           6.11%            as
           4.35%            sh
           4.14%          make
           1.13%        fixdep
      ...
    
      $ perf report -s comm -c cc1,gcc --percentage absolute
      # Overhead       Command
      # ........  ............
      #
          74.19%           cc1
           7.61%           gcc
    
      $ perf report -s comm -c cc1,gcc --percentage relative
      # Overhead       Command
      # ........  ............
      #
          90.69%           cc1
           9.31%           gcc
    
Note that it has zero effect if no filter was applied.

 * changes in v6:
  - fix a bug in --stdio group report
  - reuse __hpp__fmt() function in TUI/GTK
  - add Acked-by from Jiri

 * changes in v5:
  - fix 0 samples in relative percent output (Jiri)
  - factor hists__total_period function (Jiri)
  - share config parsing code with option parser (Jiri)

 * changes in v4:
  - support perf top and perf diff also  (Jiri)
  - add HIST_FILTER__HOST/GUEST  (Jiri)
  - retain both of filtered and total stats  (Arnaldo)
  - add 'F' hotkey on TUI  (Jiri)
  - rename config variable to have "hist." prefix


You can get this on the 'perf/percentage-v6' branch in my tree

  git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Any comments are welcome, thanks
Namhyung


Namhyung Kim (13):
  perf ui/stdio: Fix invalid output on event group report
  perf ui/gtk: Reuse generic __hpp__fmt() code
  perf ui/hists: Pass struct hpp to print functions
  perf ui/tui: Reuse generic __hpp__fmt() code
  perf tools: Pass evsel to hpp->header/width functions explicitly
  perf tools: Count periods of filtered entries separately
  perf hists: Add support for showing relative percentage
  perf report: Add --percentage option
  perf top: Add --percentage option
  perf diff: Add --percentage option
  perf tools: Add hist.percentage config option
  perf ui/tui: Add 'F' hotkey to toggle percentage output
  perf tools: Show absolute percentage by default

 tools/perf/Documentation/perf-diff.txt   |  21 +++-
 tools/perf/Documentation/perf-report.txt |  24 +++--
 tools/perf/Documentation/perf-top.txt    |  18 +++-
 tools/perf/builtin-diff.c                |  42 ++++++--
 tools/perf/builtin-report.c              |  24 ++++-
 tools/perf/builtin-top.c                 |   2 +
 tools/perf/ui/browsers/hists.c           | 161 ++++++++++++++-----------------
 tools/perf/ui/gtk/hists.c                |  89 ++++-------------
 tools/perf/ui/hist.c                     | 159 ++++++++++++++++++++----------
 tools/perf/ui/stdio/hist.c               |  11 +--
 tools/perf/util/config.c                 |   4 +
 tools/perf/util/event.c                  |  22 ++---
 tools/perf/util/hist.c                   |  65 +++++++++----
 tools/perf/util/hist.h                   |  39 +++++++-
 tools/perf/util/symbol.h                 |   5 +-
 15 files changed, 406 insertions(+), 280 deletions(-)

-- 
1.7.11.7


             reply	other threads:[~2014-03-03  1:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-03  1:14 Namhyung Kim [this message]
2014-03-03  1:14 ` [PATCH 01/13] perf ui/stdio: Fix invalid output on event group report Namhyung Kim
2014-03-18  8:29   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-03-03  1:14 ` [PATCH 02/13] perf ui/gtk: Reuse generic __hpp__fmt() code Namhyung Kim
2014-03-03 13:13   ` Pekka Enberg
2014-03-18  8:29   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-03-03  1:14 ` [PATCH 03/13] perf ui/hists: Pass struct hpp to print functions Namhyung Kim
2014-03-18  8:30   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-03-03  1:14 ` [PATCH 04/13] perf ui/tui: Reuse generic __hpp__fmt() code Namhyung Kim
2014-03-18  8:30   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-03-03  1:14 ` [PATCH 05/13] perf tools: Pass evsel to hpp->header/width functions explicitly Namhyung Kim
2014-03-03  1:14 ` [PATCH 06/13] perf tools: Count periods of filtered entries separately Namhyung Kim
2014-03-03  1:14 ` [PATCH 07/13] perf hists: Add support for showing relative percentage Namhyung Kim
2014-03-07 14:37   ` Arnaldo Carvalho de Melo
2014-03-07 14:39     ` PVT " Arnaldo Carvalho de Melo
2014-03-03  1:14 ` [PATCH 08/13] perf report: Add --percentage option Namhyung Kim
2014-03-03  1:14 ` [PATCH 09/13] perf top: " Namhyung Kim
2014-03-03  1:14 ` [PATCH 10/13] perf diff: " Namhyung Kim
2014-03-03  1:14 ` [PATCH 11/13] perf tools: Add hist.percentage config option Namhyung Kim
2014-03-03  1:14 ` [PATCH 12/13] perf ui/tui: Add 'F' hotkey to toggle percentage output Namhyung Kim
2014-03-03  1:14 ` [PATCH 13/13] perf tools: Show absolute percentage by default Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393809254-4480-1-git-send-email-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=andi@firstfloor.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome