From: Joe Perches <joe@perches.com>
To: DaeSeok Youn <daeseok.youn@gmail.com>
Cc: "Krzysztof Hałasa" <khalasa@piap.pl>,
"Greg KH" <gregkh@linuxfoundation.org>,
"sachin.kamat" <sachin.kamat@linaro.org>,
"Shaun Laing" <shaun@xresource.ca>,
"Dulshani Gunawardhana" <dulshani.gunawardhana89@gmail.com>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
devel <devel@driverdev.osuosl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5 v2] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c
Date: Sun, 02 Mar 2014 23:10:01 -0800 [thread overview]
Message-ID: <1393830601.13719.77.camel@joe-AO722> (raw)
In-Reply-To: <CAHb8M2AS2w9VBSJS9imU07ydMOZW+M-PD-Ja3iZYSTJ=2GNa-A@mail.gmail.com>
On Mon, 2014-03-03 at 16:01 +0900, DaeSeok Youn wrote:
> 2014-03-03 15:46 GMT+09:00 Krzysztof Hałasa <khalasa@piap.pl>:
> > why not use some existing *hex_dump*() instead?
> OK. but this patch is only for fix line length over 80 characters,
> right? If it can be improved as your comment,
> it must be in another patch.
Not true. Always strive to improve the code in
preference to shutting up checkpatch warnings.
next prev parent reply other threads:[~2014-03-03 7:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 7:36 Daeseok Youn
2014-03-03 6:46 ` Krzysztof Hałasa
2014-03-03 7:01 ` DaeSeok Youn
2014-03-03 7:10 ` Joe Perches [this message]
2014-03-03 7:33 ` DaeSeok Youn
2014-03-04 0:22 ` DaeSeok Youn
2014-03-04 6:40 ` Krzysztof Hałasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393830601.13719.77.camel@joe-AO722 \
--to=joe@perches.com \
--cc=daeseok.youn@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dulshani.gunawardhana89@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=khalasa@piap.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=shaun@xresource.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®