From: Sibi Sankar <quic_sibis@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Amit Kucheria <amitk@kernel.org>,
Thara Gopinath <thara.gopinath@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Georgi Djakov <djakov@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 09/15] arm64: dts: qcom: sm6375: Add CPUCP L3 node
Date: Fri, 10 Mar 2023 08:44:23 +0530 [thread overview]
Message-ID: <139384c3-5ebc-84b6-9109-b98e4690ca68@quicinc.com> (raw)
In-Reply-To: <20230303-topic-sm6375_features0_dts-v1-9-8c8d94fba6f0@linaro.org>
Hey Konrad,
Thanks for the patch.
On 3/4/23 03:28, Konrad Dybcio wrote:
> Enable the CPUCP block responsible for scaling the L3 cache.
FWIW, the patch just enables the l3 provider, the CPUCP block would
already be up at this point. You would also want to include the
expansion for CPUCP at least once in your patch.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sm6375.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6375.dtsi b/arch/arm64/boot/dts/qcom/sm6375.dtsi
> index 90f18754a63b..59d7ed25aa36 100644
> --- a/arch/arm64/boot/dts/qcom/sm6375.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6375.dtsi
> @@ -1505,6 +1505,15 @@ frame@f42d000 {
> };
> };
>
> + cpucp_l3: interconnect@fd90000 {
> + compatible = "qcom,sm6375-cpucp-l3", "qcom,epss-l3";
> + reg = <0 0x0fd90000 0 0x1000>;
> +
> + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>, <&gcc GPLL0>;
> + clock-names = "xo", "alternate";
> + #interconnect-cells = <1>;
> + };
> +
> cpufreq_hw: cpufreq@fd91000 {
> compatible = "qcom,sm6375-cpufreq-epss", "qcom,cpufreq-epss";
> reg = <0 0x0fd91000 0 0x1000>, <0 0x0fd92000 0 0x1000>;
>
next prev parent reply other threads:[~2023-03-10 3:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 21:58 [PATCH 00/15] SM6375 feature enablement (round one) Konrad Dybcio
2023-03-03 21:58 ` [PATCH 01/15] dt-bindings: thermal: qcom-tsens: Add compatible for SM6375 Konrad Dybcio
2023-03-06 8:57 ` Krzysztof Kozlowski
2023-03-03 21:58 ` [PATCH 02/15] dt-bindings: interconnect: OSM L3: Add SM6375 CPUCP compatible Konrad Dybcio
2023-03-06 8:58 ` Krzysztof Kozlowski
2023-03-03 21:58 ` [PATCH 03/15] dt-bindings: sram: qcom,imem: document SM6375 IMEM Konrad Dybcio
2023-03-06 8:58 ` Krzysztof Kozlowski
2023-03-03 21:58 ` [PATCH 04/15] arm64: dts: qcom: sm6375: Add RPM sleep stats Konrad Dybcio
2023-03-03 21:58 ` [PATCH 05/15] arm64: dts: qcom: sm6375: Add IMEM Konrad Dybcio
2023-03-03 21:58 ` [PATCH 06/15] arm64: dts: qcom: sm6375: Add RMTFS Konrad Dybcio
2023-03-03 21:58 ` [PATCH 07/15] arm64: dts: qcom: sm6375: Add wifi node Konrad Dybcio
2023-03-03 21:58 ` [PATCH 08/15] arm64: dts: qcom: sm6375: Add modem nodes Konrad Dybcio
2023-03-03 21:58 ` [PATCH 09/15] arm64: dts: qcom: sm6375: Add CPUCP L3 node Konrad Dybcio
2023-03-10 3:14 ` Sibi Sankar [this message]
2023-03-10 13:15 ` Konrad Dybcio
2023-03-03 21:58 ` [PATCH 10/15] arm64: dts: qcom: sm6375: Add TSENS Konrad Dybcio
2023-03-03 21:58 ` [PATCH 11/15] arm64: dts: qcom: sm6375: Configure TSENS thermal zones Konrad Dybcio
2023-03-03 21:58 ` [PATCH 12/15] arm64: dts: qcom: sm6375: Introduce MPM support Konrad Dybcio
2023-03-14 23:57 ` Konrad Dybcio
2023-03-03 21:58 ` [PATCH 13/15] arm64: dts: qcom: sm6375: Bump CPU rail power collapse index Konrad Dybcio
2023-03-03 21:58 ` [PATCH 14/15] arm64: dts: qcom: sm6375: Introduce C3 power state for both ARM clusters Konrad Dybcio
2023-03-03 21:58 ` [PATCH 15/15] arm64: dts: qcom: sm6375-pdx225: Add volume down GPIO key Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=139384c3-5ebc-84b6-9109-b98e4690ca68@quicinc.com \
--to=quic_sibis@quicinc.com \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®