From: Josh Cartwright <joshc@codeaurora.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, Felipe Balbi <balbi@ti.com>
Subject: [PATCH 2/2] spmi: pm: drop bus-level PM suspend/resume routines
Date: Mon, 3 Mar 2014 10:49:44 -0600 [thread overview]
Message-ID: <1393865384-28145-2-git-send-email-joshc@codeaurora.org> (raw)
In-Reply-To: <1393865384-28145-1-git-send-email-joshc@codeaurora.org>
SPMI defines the behavior of a device in the "SLEEP" state as being
"user-defined or specified by the device manufacturer". Without
clearly-defined bus-level semantics for low-power states, push the
responsibility of transitioning a device into/out of "SLEEP" into SPMI
device drivers.
Cc: Felipe Balbi <balbi@ti.com>
Signed-off-by: Josh Cartwright <joshc@codeaurora.org>
---
drivers/spmi/spmi.c | 35 -----------------------------------
1 file changed, 35 deletions(-)
diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
index 6122c8f..3b57807 100644
--- a/drivers/spmi/spmi.c
+++ b/drivers/spmi/spmi.c
@@ -46,40 +46,6 @@ static const struct device_type spmi_ctrl_type = {
.release = spmi_ctrl_release,
};
-#ifdef CONFIG_PM_RUNTIME
-static int spmi_runtime_suspend(struct device *dev)
-{
- struct spmi_device *sdev = to_spmi_device(dev);
- int err;
-
- err = pm_generic_runtime_suspend(dev);
- if (err)
- return err;
-
- return spmi_command_sleep(sdev);
-}
-
-static int spmi_runtime_resume(struct device *dev)
-{
- struct spmi_device *sdev = to_spmi_device(dev);
- int err;
-
- err = spmi_command_wakeup(sdev);
- if (err)
- return err;
-
- return pm_generic_runtime_resume(dev);
-}
-#endif
-
-static const struct dev_pm_ops spmi_pm_ops = {
- SET_RUNTIME_PM_OPS(
- spmi_runtime_suspend,
- spmi_runtime_resume,
- NULL
- )
-};
-
static int spmi_device_match(struct device *dev, struct device_driver *drv)
{
if (of_driver_match_device(dev, drv))
@@ -391,7 +357,6 @@ static int spmi_drv_remove(struct device *dev)
static struct bus_type spmi_bus_type = {
.name = "spmi",
.match = spmi_device_match,
- .pm = &spmi_pm_ops,
.probe = spmi_drv_probe,
.remove = spmi_drv_remove,
};
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-03-03 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 16:49 [PATCH 1/2] spmi: pmic_arb: make selectable on ARCH_QCOM Josh Cartwright
2014-03-03 16:49 ` Josh Cartwright [this message]
2014-03-03 17:06 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393865384-28145-2-git-send-email-joshc@codeaurora.org \
--to=joshc@codeaurora.org \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome