From: Felipe Balbi <balbi@ti.com>
To: <airlied@linux.ie>
Cc: <airlied@redhat.com>, <robdclark@gmail.com>, <bparrot@ti.com>,
<dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Darren Etheridge <detheridge@ti.com>
Subject: [PATCH] drm/tilcdc: restore correct display mode and contents on pm resume
Date: Mon, 3 Mar 2014 13:08:56 -0600 [thread overview]
Message-ID: <1393873736-26867-1-git-send-email-balbi@ti.com> (raw)
From: Darren Etheridge <detheridge@ti.com>
On resume the screen contents were not being restored properly. Looking at
other DRM drivers it seems a call to drm_helper_resume_force_mode() is needed
in the resume handler to force restoration of the mode and framebuffer data.
Signed-off-by: Darren Etheridge <detheridge@ti.com>
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 171a820..1a5ddfa 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -563,6 +563,13 @@ static int tilcdc_pm_resume(struct device *dev)
if (registers[i].save && (priv->rev >= registers[i].rev))
tilcdc_write(ddev, registers[i].reg, priv->saved_register[n++]);
+ /*
+ * if this call isn't here, the display is blank on return from
+ * suspend. With this call here the contents of the framebuffer
+ * during suspend are restored correctly.
+ */
+ drm_helper_resume_force_mode(ddev);
+
drm_kms_helper_poll_enable(ddev);
return 0;
--
1.9.0
next reply other threads:[~2014-03-03 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 19:08 Felipe Balbi [this message]
2014-04-24 17:58 ` Felipe Balbi
2014-04-24 20:48 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393873736-26867-1-git-send-email-balbi@ti.com \
--to=balbi@ti.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=bparrot@ti.com \
--cc=detheridge@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®