From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
Namhyung Kim <namhyung@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>
Subject: [RFC 00/10] perf report: Add -F option for specifying output fields
Date: Tue, 4 Mar 2014 11:42:06 +0900 [thread overview]
Message-ID: <1393900936-22977-1-git-send-email-namhyung@kernel.org> (raw)
Hello,
This is a patchset implementing -F/--field option to setup output
field/column as Ingo requested.
The -F option can receive any sort keys that -s option recognize, plus
following fields (name can be changed):
overhead, overhead_sys, overhead_us, sample, period
The overhead_guest_sys and overhead_guest_us might be avaiable when
you profile guest machines.
Output will be sorted by in order of fields and sort keys passed by -s
option will be added to the output field list automatically. If you
want to change the order of sorting you can give -s option in addition
to -F option. To support old behavior, it'll also prepend 'overhead'
field to the sort keys unless you give -F option explicitly.
$ perf report -s dso,sym
...
# Overhead Shared Object Symbol
# ........ ............. ..........................
#
13.75% ld-2.17.so [.] strcmp
10.00% abc [.] a
10.00% abc [.] b
10.00% abc [.] c
8.75% abc [.] main
7.50% libc-2.17.so [.] _setjmp
6.25% abc [.] _init
6.25% abc [.] frame_dummy
5.00% abc [.] __libc_csu_init
5.00% ld-2.17.so [.] _dl_name_match_p
3.75% libc-2.17.so [.] __new_exitfn
2.50% libc-2.17.so [.] __cxa_atexit
1.25% ld-2.17.so [.] _dl_check_map_versions
1.25% ld-2.17.so [.] _dl_setup_hash
1.25% ld-2.17.so [.] _dl_sysdep_start
1.25% ld-2.17.so [.] brk
1.25% ld-2.17.so [.] calloc@plt
1.25% ld-2.17.so [.] dl_main
1.25% ld-2.17.so [.] match_symbol
1.25% ld-2.17.so [.] sbrk
1.25% ld-2.17.so [.] strlen
$ perf report -F sym,sample,overhead
...
# Symbol Samples Overhead
# .......................... ............ ........
#
[.] __cxa_atexit 2 2.50%
[.] __libc_csu_init 4 5.00%
[.] __new_exitfn 3 3.75%
[.] _dl_check_map_versions 1 1.25%
[.] _dl_name_match_p 4 5.00%
[.] _dl_setup_hash 1 1.25%
[.] _dl_sysdep_start 1 1.25%
[.] _init 5 6.25%
[.] _setjmp 6 7.50%
[.] a 8 10.00%
[.] b 8 10.00%
[.] brk 1 1.25%
[.] c 8 10.00%
[.] calloc@plt 1 1.25%
[.] dl_main 1 1.25%
[.] frame_dummy 5 6.25%
[.] main 7 8.75%
[.] match_symbol 1 1.25%
[.] sbrk 1 1.25%
[.] strcmp 11 13.75%
[.] strlen 1 1.25%
$ perf report -F sym,sample -s overhead
...
# Symbol Samples Overhead
# .......................... ............ ........
#
[.] strcmp 11 13.75%
[.] a 8 10.00%
[.] b 8 10.00%
[.] c 8 10.00%
[.] main 7 8.75%
[.] _setjmp 6 7.50%
[.] _init 5 6.25%
[.] frame_dummy 5 6.25%
[.] __libc_csu_init 4 5.00%
[.] _dl_name_match_p 4 5.00%
[.] __new_exitfn 3 3.75%
[.] __cxa_atexit 2 2.50%
[.] _dl_check_map_versions 1 1.25%
[.] _dl_setup_hash 1 1.25%
[.] _dl_sysdep_start 1 1.25%
[.] brk 1 1.25%
[.] calloc@plt 1 1.25%
[.] dl_main 1 1.25%
[.] match_symbol 1 1.25%
[.] sbrk 1 1.25%
[.] strlen 1 1.25%
I pushed the patch series on the 'perf/field-v1' branch in my tree
git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Any comments are welcome, please test!
Thanks,
Namhyung
Namhyung Kim (10):
perf tools: Add ->cmp(), ->collapse() and ->sort() to perf_hpp_fmt
perf tools: Convert sort entries to hpp formats
perf tools: Use hpp formats to sort hist entries
perf tools: Support event grouping in hpp ->sort()
perf tools: Use hpp formats to sort final output
perf tools: Consolidate output field handling to hpp format routines
perf ui: Get rid of callback from __hpp__fmt()
perf tools: Allow hpp fields to be sort keys
perf report: Add -F option to specify output fields
perf tools: Add ->sort() member to struct sort_entry
tools/perf/Documentation/perf-report.txt | 10 ++
tools/perf/builtin-report.c | 8 +
tools/perf/ui/browsers/hists.c | 66 +++-----
tools/perf/ui/gtk/hists.c | 33 +---
tools/perf/ui/hist.c | 189 +++++++++++++++++++---
tools/perf/ui/stdio/hist.c | 52 ++----
tools/perf/util/hist.c | 78 ++-------
tools/perf/util/hist.h | 18 ++-
tools/perf/util/sort.c | 269 ++++++++++++++++++++++++++++++-
tools/perf/util/sort.h | 3 +
10 files changed, 520 insertions(+), 206 deletions(-)
--
1.7.11.7
next reply other threads:[~2014-03-04 2:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 2:42 Namhyung Kim [this message]
2014-03-04 2:42 ` [PATCH 01/10] perf tools: Add ->cmp(), ->collapse() and ->sort() to perf_hpp_fmt Namhyung Kim
2014-03-04 2:42 ` [PATCH 02/10] perf tools: Convert sort entries to hpp formats Namhyung Kim
2014-03-04 2:42 ` [PATCH 03/10] perf tools: Use hpp formats to sort hist entries Namhyung Kim
2014-03-04 2:42 ` [PATCH 04/10] perf tools: Support event grouping in hpp ->sort() Namhyung Kim
2014-03-04 2:42 ` [PATCH 05/10] perf tools: Use hpp formats to sort final output Namhyung Kim
2014-03-04 2:42 ` [PATCH 06/10] perf tools: Consolidate output field handling to hpp format routines Namhyung Kim
2014-03-04 2:42 ` [PATCH 07/10] perf ui: Get rid of callback from __hpp__fmt() Namhyung Kim
2014-03-04 2:42 ` [PATCH 08/10] perf tools: Allow hpp fields to be sort keys Namhyung Kim
2014-03-04 2:42 ` [PATCH 09/10] perf report: Add -F option to specify output fields Namhyung Kim
2014-03-04 2:42 ` [PATCH 10/10] perf tools: Add ->sort() member to struct sort_entry Namhyung Kim
2014-03-04 2:45 ` [RFC 00/10] perf report: Add -F option for specifying output fields Namhyung Kim
2014-03-04 7:19 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393900936-22977-1-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®