From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754646AbaCDQLY (ORCPT ); Tue, 4 Mar 2014 11:11:24 -0500 Received: from mail-pb0-f43.google.com ([209.85.160.43]:42828 "EHLO mail-pb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754354AbaCDQLU (ORCPT ); Tue, 4 Mar 2014 11:11:20 -0500 Message-ID: <1393949476.26794.118.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH net-next 08/12] r8152: support TSO From: Eric Dumazet To: Hayes Wang Cc: netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Tue, 04 Mar 2014 08:11:16 -0800 In-Reply-To: <1393934464-23675-9-git-send-email-hayeswang@realtek.com> References: <1393934464-23675-1-git-send-email-hayeswang@realtek.com> <1393934464-23675-9-git-send-email-hayeswang@realtek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-03-04 at 20:01 +0800, Hayes Wang wrote: > +static u32 r8152_xmit_frags(struct r8152 *tp, struct sk_buff *skb, u8 *data) > +{ > + struct skb_shared_info *info = skb_shinfo(skb); > + unsigned int cur_frag; > + u32 total = skb_headlen(skb); > + > + memcpy(data, skb->data, total); > + data += total; > + > + for (cur_frag = 0; cur_frag < info->nr_frags; cur_frag++) { > + const skb_frag_t *frag = info->frags + cur_frag; > + void *addr; > + u32 len; > + > + len = skb_frag_size(frag); > + addr = skb_frag_address(frag); > + memcpy(data, addr, len); > + data += len; > + total += len; > } > + > + return total; > } > I would rather use skb_copy_bits(), because it correctly handles kmap() case. (If a frag resides in high memory)