From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757938AbaCDWeS (ORCPT ); Tue, 4 Mar 2014 17:34:18 -0500 Received: from smtp.citrix.com ([66.165.176.89]:53788 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757874AbaCDWd3 (ORCPT ); Tue, 4 Mar 2014 17:33:29 -0500 X-IronPort-AV: E=Sophos;i="4.97,588,1389744000"; d="scan'208";a="108145555" From: Zoltan Kiss To: , , CC: , , , Zoltan Kiss Subject: [PATCH net-next v6 8/10] xen-netback: Add stat counters for frag_list skbs Date: Tue, 4 Mar 2014 22:32:19 +0000 Message-ID: <1393972341-21135-9-git-send-email-zoltan.kiss@citrix.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1393972341-21135-1-git-send-email-zoltan.kiss@citrix.com> References: <1393972341-21135-1-git-send-email-zoltan.kiss@citrix.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.2.133] X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These counters help determine how often the guest sends a packet with more than MAX_SKB_FRAGS frags. NOTE: if bisect brought you here, you should apply the series up until #9, otherwise malicious guests can block other guests by not releasing their sent packets. Signed-off-by: Zoltan Kiss --- drivers/net/xen-netback/common.h | 1 + drivers/net/xen-netback/interface.c | 7 +++++++ drivers/net/xen-netback/netback.c | 1 + 3 files changed, 9 insertions(+) diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h index eac171e..d8a2298 100644 --- a/drivers/net/xen-netback/common.h +++ b/drivers/net/xen-netback/common.h @@ -170,6 +170,7 @@ struct xenvif { unsigned long tx_zerocopy_sent; unsigned long tx_zerocopy_success; unsigned long tx_zerocopy_fail; + unsigned long tx_frag_overflow; /* Miscellaneous private stuff. */ struct net_device *dev; diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c index adfed30..ba5be2f 100644 --- a/drivers/net/xen-netback/interface.c +++ b/drivers/net/xen-netback/interface.c @@ -252,6 +252,13 @@ static const struct xenvif_stat { "tx_zerocopy_fail", offsetof(struct xenvif, tx_zerocopy_fail) }, + /* Number of packets exceeding MAX_SKB_FRAG slots. You should use + * a guest with the same MAX_SKB_FRAG + */ + { + "tx_frag_overflow", + offsetof(struct xenvif, tx_frag_overflow) + }, }; static int xenvif_get_sset_count(struct net_device *dev, int string_set)