From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755790AbaCEMJF (ORCPT ); Wed, 5 Mar 2014 07:09:05 -0500 Received: from gerolde.archlinux.org ([66.211.214.132]:39250 "EHLO gerolde.archlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753246AbaCEMJE (ORCPT ); Wed, 5 Mar 2014 07:09:04 -0500 X-Greylist: delayed 581 seconds by postgrey-1.27 at vger.kernel.org; Wed, 05 Mar 2014 07:09:03 EST From: =?UTF-8?q?Thomas=20B=C3=A4chler?= To: Marcel Holtmann Cc: Gustavo Padovan , Johan Hedberg , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Thomas=20B=C3=A4chler?= Subject: [PATCH] Revert "Bluetooth: Use devname:vhci module alias for virtual HCI driver" Date: Wed, 5 Mar 2014 12:59:12 +0100 Message-Id: <1394020752-6186-1-git-send-email-thomas@archlinux.org> X-Mailer: git-send-email 1.9.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding the devname:vhci alias and thus adding a static /dev/vhci device node only works when assigning a fixed major/minor number. However, the code currently uses a dynamically assigned minor number. It is therefore impossible to create a static device and to autoload the module when accessing it. Reverting this fixes the kmod error message depmod: ERROR: Module 'hci_vhci' has devname (vhci) but lacks major and minor information. Ignoring. This reverts commit bfacbb9aec029b3200053d84c8cd5d7575f2d4a5. --- drivers/bluetooth/hci_vhci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c index 1ef6990..cf05d70 100644 --- a/drivers/bluetooth/hci_vhci.c +++ b/drivers/bluetooth/hci_vhci.c @@ -384,4 +384,3 @@ MODULE_AUTHOR("Marcel Holtmann "); MODULE_DESCRIPTION("Bluetooth virtual HCI driver ver " VERSION); MODULE_VERSION(VERSION); MODULE_LICENSE("GPL"); -MODULE_ALIAS("devname:vhci"); -- 1.9.0